[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 4/6] net: force NetQue opaque to be NetClient
|
From: |
liu ping fan |
|
Subject: |
Re: [Qemu-devel] [PATCH v2 4/6] net: force NetQue opaque to be NetClientState |
|
Date: |
Thu, 20 Jun 2013 14:30:49 +0800 |
On Tue, Jun 18, 2013 at 8:47 PM, Stefan Hajnoczi <address@hidden> wrote:
> On Thu, Jun 13, 2013 at 05:03:04PM +0800, Liu Ping Fan wrote:
>> From: Liu Ping Fan <address@hidden>
>>
>> qemu_net_client_setup() is the only user of qemu_new_net_queue(), which
>> will pass in NetClientState. By forcing it be a NetClientState, we
>> can ref/unref NetQueue's owner
>
> Please s/opaque/nc/ in net/queue.[hc] since it's no longer "opaque" :).
>
Ok, I will.
> Also, qemu_deliver_packet()/qemu_deliver_packet_iov() can take an
> NetClientState *nc instead of void *opaque.
>
>> Signed-off-by: Liu Ping Fan <address@hidden>
>
> pingfank here and pingfanl in the From: header. Are both okay and which
> do you prefer to use?
Change my disk, totally re-install my system, and mix up with internal
mail address. Will fix it.
Thx & regards,
Pingfan
[Qemu-devel] [PATCH v2 6/6] net: hub use lock to protect ports list, Liu Ping Fan, 2013/06/13
Re: [Qemu-devel] [PATCH v2 0/6] port network layer onto glib, Stefan Hajnoczi, 2013/06/18