[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH 12/12] spapr-vty: remove unfixable FIXME
From: |
Anthony Liguori |
Subject: |
[Qemu-devel] [PATCH 12/12] spapr-vty: remove unfixable FIXME |
Date: |
Wed, 19 Jun 2013 15:40:35 -0500 |
Signed-off-by: Anthony Liguori <address@hidden>
---
hw/char/spapr_vty.c | 8 +++++++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/hw/char/spapr_vty.c b/hw/char/spapr_vty.c
index aa56f10..6834fe2 100644
--- a/hw/char/spapr_vty.c
+++ b/hw/char/spapr_vty.c
@@ -65,7 +65,13 @@ static int spapr_vty_getchars(VIOsPAPRVTYDevice *dev,
uint8_t *buf, int max)
static void spapr_vty_putchars(VIOsPAPRVTYDevice *dev,
const uint8_t *buf, int len)
{
- /* FIXME: should check the qemu_chr_fe_write() return value */
+ /* There is no flow control with this interface so we can't really
+ * do anything if we are unable to write out data. So we ignore errors
+ * here and silently drop the data.
+ *
+ * Our only option would be buffering but the kernel already has a buffer
+ * so that would only delay the inevitable.
+ */
qemu_chr_fe_write(dev->chardev, buf, len);
}
--
1.8.0
- [Qemu-devel] [PATCH 09/12] spapr-vio: move special case handling for reg=0 to vio, (continued)
[Qemu-devel] [PATCH 08/12] spapr-rtas: use hypercall interface and remove special vty interfaces, Anthony Liguori, 2013/06/19
[Qemu-devel] [PATCH 12/12] spapr-vty: remove unfixable FIXME,
Anthony Liguori <=
[Qemu-devel] [PATCH 10/12] spapr-vty: refactor the code to improve consistency, Anthony Liguori, 2013/06/19
[Qemu-devel] [PATCH 04/12] qtest: add interface to save/restore, Anthony Liguori, 2013/06/19
[Qemu-devel] [PATCH 07/12] spapr-rtas: add CPU argument to RTAS calls, Anthony Liguori, 2013/06/19
[Qemu-devel] [PATCH 11/12] spapr-vio: pass type to spapr_vio_find_by_reg(), Anthony Liguori, 2013/06/19