[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [RFT PATCH] configure: Simplify alternate .text segment

From: Ed Maste
Subject: Re: [Qemu-devel] [RFT PATCH] configure: Simplify alternate .text segment
Date: Wed, 19 Jun 2013 15:57:02 -0400

On 19 June 2013 14:25, Richard Henderson <address@hidden> wrote:
> Given the large variance in the true default, I wonder if we shouldn't ignore
> it entirely.  I wonder if we can't edit more like this:
>   s/[.] = .* [+] SIZEOF_HEADERS/. = $textseg_addr + SIZEOF_HEADERS/

Sounds good, although we need to pick up __executable_start too I
think; from my ld --verbose:
#  PROVIDE (__executable_start = 0x400000); . = 0x400000 + SIZEOF_HEADERS;

How about this?

      $ld --verbose | sed \
        -e '1,/==================================================/d' \
        -e '/==================================================/,$d' \
        -e "s/[.] = .* [+] SIZEOF_HEADERS/. = $textseg_addr + SIZEOF_HEADERS/" \
        -e "s/__executable_start = [0-9x]*/__executable_start =
$textseg_addr/" > config-host.ld

> I note that the current mips.ld file, from whence you took your "new" address,
> is the same as the real default.  I.e. no movement.  I suspect that we can
> actually move the binary to 0x60000000 with the rest of the targets.  Failing
> that, we should move mips to the "don't change" category.
> I also suggest that ia64 be moved to the "don't change" category.  It's 
> default
> text address is 0x4000000000000000, which is as far out of the way of the 
> guest
> address space as we can get.

Both sound reasonable, although I don't have an easy way to test
either platform at the moment.  We can always make those changes
after, or I am happy to respin the patch.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]