[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v5 10/11] blockdev: add Abort transaction
From: |
Kevin Wolf |
Subject: |
Re: [Qemu-devel] [PATCH v5 10/11] blockdev: add Abort transaction |
Date: |
Wed, 19 Jun 2013 13:21:42 +0200 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
Am 03.06.2013 um 11:21 hat Stefan Hajnoczi geschrieben:
> On Thu, May 30, 2013 at 07:11:25AM -0600, Eric Blake wrote:
> > On 05/30/2013 06:34 AM, Stefan Hajnoczi wrote:
> > > The Abort action can be used to test QMP 'transaction' failure. Add it
> > > as the last action to exercise the .abort() and .cleanup() code paths
> > > for all previous actions.
> >
> > Another thread questioned whether we should name this action
> > __org.qemu-debug-abort, if only to be clear that it is not a normal
> > interface.
>
> kwolf: Do you want Abort to be namespaced as a debug-only action?
>
> I think it's perfectly supportable so there's no need to hide it.
> Granted it's rare that anyone would want to use this action.
I don't have a strong opinion on this. On the one hand it's probably
useless outside testing and debugging, on the other hand it won't be a
pain to support and the interface looks like it could be stable for
the next few years...
It's your patch, so you get to decide.
Reviewed-by: Kevin Wolf <address@hidden>