[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v5 08/11] blockdev: allow BdrvActionOps->commit(
From: |
Kevin Wolf |
Subject: |
Re: [Qemu-devel] [PATCH v5 08/11] blockdev: allow BdrvActionOps->commit() to be NULL |
Date: |
Wed, 19 Jun 2013 13:14:32 +0200 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
Am 30.05.2013 um 14:34 hat Stefan Hajnoczi geschrieben:
> Some QMP 'transaction' types don't need to do anything on .commit().
> Make .commit() optional just like .abort().
>
> The "drive-backup" action will take advantage of this, it only needs to
> cancel the block job on .abort(). Other block job actions will probably
> follow the same pattern, so allow .commit() to be NULL.
>
> Suggested-by: Eric Blake <address@hidden>
> Signed-off-by: Stefan Hajnoczi <address@hidden>
Reviewed-by: Kevin Wolf <address@hidden>