Re: [Qemu-devel] [PATCH V2 12/12] qemu-iotests: add 055 internal snapshot for block device test case

[Wenchao Xia]

> On Wed, Jun 19, 2013 at 02:21:31PM +0800, Wenchao Xia wrote:
> > 于 2013-6-18 22:32, Stefan Hajnoczi 写道:
> > > On Fri, Jun 14, 2013 at 07:39:59PM +0800, Wenchao Xia wrote:
> > > > +    def createSnapshotInTransaction(self, snapshot_num):
> > > > +        actions = []
> > > > +        for i in range(0, len(self.expect)):
> > > > +            num = self.expect[i]['snapshots_name_counter']
> > > > +            for j in range(0, snapshot_num):
> > > > +                name = '%s_sn%d' % (self.expect[i]['device'], num)
> > > > +                num = num + 1
> > > > +                self.expect[i]['snapshots'].append(name)
> > > > +                actions.append({
> > > > +                    'type': 'blockdev-snapshot-internal-sync',
> > > > +                    'data': { 'device': self.expect[i]['device'],
> > > > +                              'name': name },
> > > > +                })
> > > > +            self.expect[i]['snapshots_name_counter'] = num
> > > > +        result = self.vm.qmp('transaction', actions = actions)
> > > > +        self.assert_qmp(result, 'return', {})
> > >
> > > This tests the success case.  Please also use the 'Abort' action to test
> > > the error case.
> >    Is "Abort" upstreamed? If yes I will add that part.
>
> It's part of the drive-backup series which you have already
> cherry-picked from.
  Will you continue work on drive-backup? I'd like to rebase this
serial after your v6, to reduce conflict.

--
Best Regards

Wenchao Xia