[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [RfC PATCH 2/2] console: add screendump-device qmp cmd
From: |
Gerd Hoffmann |
Subject: |
Re: [Qemu-devel] [RfC PATCH 2/2] console: add screendump-device qmp cmd |
Date: |
Tue, 18 Jun 2013 15:24:33 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130513 Thunderbird/17.0.6 |
Hi,
>> Something like the attached patch? Which is just the bare minimum I'll
>> need for screendump. Basically a one-off bottom half with some monitor
>> infrastructure (job id, error handling). So it isn't for big jobs, but
>> for small jobs which have to wait for something before they execute
>> (spice-server, guest action, whatever).
>
> I only skimmed over the patch, but you need QMP commands to cancel
> and to query running jobs.
Sure, can easily go on top, just need to stuff the monitor_jobs into a
list and allow ops on it. Just want to make sure the direction I'm
heading to is fine.
> Also, please move all this stuff to qmp.c
> and do s/monitor/qmp rename.
Will do.
> Lastly, is it possible to have the block job QMP API on top of this
> new QMP job API?
Don't think so. As mentioned above this does short-running jobs as
bottom half whereas block jobs are running in coroutines ...
cheers,
Gerd
- [Qemu-devel] [RfC PATCH 0/2] new screendump qmp command, Gerd Hoffmann, 2013/06/17
- [Qemu-devel] [RfC PATCH 2/2] console: add screendump-device qmp cmd, Gerd Hoffmann, 2013/06/17
- Re: [Qemu-devel] [RfC PATCH 2/2] console: add screendump-device qmp cmd, Anthony Liguori, 2013/06/17
- Re: [Qemu-devel] [RfC PATCH 2/2] console: add screendump-device qmp cmd, Luiz Capitulino, 2013/06/17
- Re: [Qemu-devel] [RfC PATCH 2/2] console: add screendump-device qmp cmd, Gerd Hoffmann, 2013/06/18
- Re: [Qemu-devel] [RfC PATCH 2/2] console: add screendump-device qmp cmd, Luiz Capitulino, 2013/06/18
- Re: [Qemu-devel] [RfC PATCH 2/2] console: add screendump-device qmp cmd,
Gerd Hoffmann <=
- Re: [Qemu-devel] [RfC PATCH 2/2] console: add screendump-device qmp cmd, Stefan Hajnoczi, 2013/06/18
- Re: [Qemu-devel] [RfC PATCH 2/2] console: add screendump-device qmp cmd, Gerd Hoffmann, 2013/06/25
[Qemu-devel] [RfC PATCH 1/2] display update with notification, Gerd Hoffmann, 2013/06/17