[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v1 5/5] nand: Don't inherit from Sysbus
From: |
peter . crosthwaite |
Subject: |
[Qemu-devel] [PATCH v1 5/5] nand: Don't inherit from Sysbus |
Date: |
Tue, 18 Jun 2013 21:12:41 +1000 |
From: Peter Crosthwaite <address@hidden>
Nand chips are not sysbus devices - they do not have any sense of MMIO,
nor interrupts. Re-parent to TYPE_DEVICE accordingly.
Cc: address@hidden
Signed-off-by: Peter Crosthwaite <address@hidden>
---
hw/block/nand.c | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/hw/block/nand.c b/hw/block/nand.c
index 8dca3bc..072de7c 100644
--- a/hw/block/nand.c
+++ b/hw/block/nand.c
@@ -21,7 +21,7 @@
# include "hw/hw.h"
# include "hw/block/flash.h"
# include "sysemu/blockdev.h"
-# include "hw/sysbus.h"
+#include "hw/qdev.h"
#include "qemu/error-report.h"
# define NAND_CMD_READ0 0x00
@@ -54,7 +54,8 @@
typedef struct NANDFlashState NANDFlashState;
struct NANDFlashState {
- SysBusDevice busdev;
+ DeviceState parent_obj;
+
uint8_t manf_id, chip_id;
uint8_t buswidth; /* in BYTES */
int size, pages;
@@ -440,7 +441,7 @@ static void nand_class_init(ObjectClass *klass, void *data)
static const TypeInfo nand_info = {
.name = TYPE_NAND,
- .parent = TYPE_SYS_BUS_DEVICE,
+ .parent = TYPE_DEVICE,
.instance_size = sizeof(NANDFlashState),
.class_init = nand_class_init,
};
--
1.8.3.rc1.44.gb387c77.dirty
[Qemu-devel] [PATCH v1 2/5] block/nand: Formatting sweep, peter . crosthwaite, 2013/06/18
[Qemu-devel] [PATCH v1 3/5] block/nand: QOM casting sweep, peter . crosthwaite, 2013/06/18
[Qemu-devel] [PATCH v1 4/5] block/nand: Convert Sysbus::init to Device::realize, peter . crosthwaite, 2013/06/18
[Qemu-devel] [PATCH v1 5/5] nand: Don't inherit from Sysbus,
peter . crosthwaite <=
Re: [Qemu-devel] [PATCH v1 0/5] Nand Cleanup, Peter Maydell, 2013/06/25