[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [RFC PATCH v1 0/7] QOM Super class access

From: Andreas Färber
Subject: Re: [Qemu-devel] [RFC PATCH v1 0/7] QOM Super class access
Date: Tue, 18 Jun 2013 12:41:29 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130510 Thunderbird/17.0.6

Am 18.06.2013 12:23, schrieb Michael S. Tsirkin:
> On Tue, Jun 18, 2013 at 07:43:11PM +1000, address@hidden wrote:
>> From: Peter Crosthwaite <address@hidden>
>> This series enables QOM super class access and demostrates some usages.
>> Replaces the save->override->call via FooClass technique, to reduce
>> some of the boiler plate in recently fully QOMified devices.
>> Applied the change to ARM CPU, MB CPU and some of Andreas's recently
>> QOMified i386 devices, all which have the save->override->call issue.
>> ARMCPU I've done a brief test on and seems to work.
>> ARM CPU was particularly difficult, as it has 3 layers of heirachy,
>> where a non-concrete class (TYPE_ARM_CPU) need to super class itself
>> (to TYPE_CPU). This sees the need for super-classers to specify their
>> expected base class level. See patches for illustration.
>> The main future work to the series is to apply the change pattern to
>> the reset of the tree
> Looks good to me overall.
> Some nits:
> - Super is an immediate parent in java and python.
> - One of the design points of QOM is that it let
>   you ignore which class is a parent and which is a child.
>   All casts look the same.
> So, why do we need the new APIs with _SUPER?
> What's wrong with simple
>       object_class_by_name()
> and casting to that?

I guess the idea was to avoid open-coding that multiple times, but I
think I would then prefer something more local like


and then use


as needed. What do you think?


SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg

reply via email to

[Prev in Thread] Current Thread [Next in Thread]