[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [RfC PATCH 2/2] console: add screendump-device qmp cmd
From: |
Gerd Hoffmann |
Subject: |
Re: [Qemu-devel] [RfC PATCH 2/2] console: add screendump-device qmp cmd |
Date: |
Tue, 18 Jun 2013 11:24:54 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130513 Thunderbird/17.0.6 |
On 06/17/13 16:50, Luiz Capitulino wrote:
>>> > > +struct screendump_job {
>>> > > + QEMUBH *bh;
>>> > > + QemuConsole *con;
>>> > > + char *filename;
>>> > > +};
>> >
>> > We have a job API in the block layer. Would it make sense to have a
>> > QMP-level job interface?
> I'd agree with this.
Something like the attached patch? Which is just the bare minimum I'll
need for screendump. Basically a one-off bottom half with some monitor
infrastructure (job id, error handling). So it isn't for big jobs, but
for small jobs which have to wait for something before they execute
(spice-server, guest action, whatever).
If you wanna some more context: screendump on top of that is here:
https://www.kraxel.org/cgit/qemu/log/?h=rebase/pixman
[ not tested yet ]
cheers,
Gerd
0001-draft-monitor-job.patch
Description: Text document
- [Qemu-devel] [RfC PATCH 0/2] new screendump qmp command, Gerd Hoffmann, 2013/06/17
- [Qemu-devel] [RfC PATCH 2/2] console: add screendump-device qmp cmd, Gerd Hoffmann, 2013/06/17
- Re: [Qemu-devel] [RfC PATCH 2/2] console: add screendump-device qmp cmd, Anthony Liguori, 2013/06/17
- Re: [Qemu-devel] [RfC PATCH 2/2] console: add screendump-device qmp cmd, Luiz Capitulino, 2013/06/17
- Re: [Qemu-devel] [RfC PATCH 2/2] console: add screendump-device qmp cmd,
Gerd Hoffmann <=
- Re: [Qemu-devel] [RfC PATCH 2/2] console: add screendump-device qmp cmd, Luiz Capitulino, 2013/06/18
- Re: [Qemu-devel] [RfC PATCH 2/2] console: add screendump-device qmp cmd, Gerd Hoffmann, 2013/06/18
- Re: [Qemu-devel] [RfC PATCH 2/2] console: add screendump-device qmp cmd, Stefan Hajnoczi, 2013/06/18
- Re: [Qemu-devel] [RfC PATCH 2/2] console: add screendump-device qmp cmd, Gerd Hoffmann, 2013/06/25
[Qemu-devel] [RfC PATCH 1/2] display update with notification, Gerd Hoffmann, 2013/06/17