|
From: | Hervé Poussineau |
Subject: | Re: [Qemu-devel] [PATCH v2 0/8] memory: remove old_portio usage |
Date: | Mon, 17 Jun 2013 22:39:25 +0200 |
User-agent: | Thunderbird 2.0.0.23 (Windows/20090812) |
Jan Kiszka a écrit :
On 2013-06-17 09:32, Paolo Bonzini wrote:Il 16/06/2013 20:20, Hervé Poussineau ha scritto:Hervé Poussineau a écrit :These proposed patches aim at removing the .old_portio member of MemoryRegionOps structure, and replacing their usage by .read/.write handlers.Ping.Jan has patches that do something similar, so I was hoping he'd look at it. Jan, are you back from vacation? :)Yes, and that is the problem. ;)From a quick glance, I'm a bit skeptical, Hervé, that your patches areaddressing all corner cases like mine. Did you see http://thread.gmane.org/gmane.comp.emulators.qemu/210188? Jan
My patches are less intrusive than yours, because they are probably less complex. They don't change subpage handling, they don't remove the register_ioport_*, and they don't move ioport handling to memory core.
However, my patches do not add a new base address field in MemoryRegion, and also simplify cpu_in/out to be simply a call to address_space_read/write (like yours).
I don't really care whatever way is chosen. I'm only interested to be able to put I/O address space into memory space, so I can improve PReP emulation.
Hervé
[Prev in Thread] | Current Thread | [Next in Thread] |