[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL 8/9] block: bdrv_reopen_prepare(): don't use QERR_OPE
From: |
Luiz Capitulino |
Subject: |
[Qemu-devel] [PULL 8/9] block: bdrv_reopen_prepare(): don't use QERR_OPEN_FILE_FAILED |
Date: |
Mon, 17 Jun 2013 11:57:10 -0400 |
The call to drv->bdrv_reopen_prepare() can fail due to reasons
other than an open failure. Unfortunately, we can't use errno
nor -ret, cause they are not always set.
Stick to a generic error message then.
Signed-off-by: Luiz Capitulino <address@hidden>
Reviewed-by: Stefan Hajnoczi <address@hidden>
Acked-by: Kevin Wolf <address@hidden>
---
block.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/block.c b/block.c
index 79ad33d..b88ad2f 100644
--- a/block.c
+++ b/block.c
@@ -1291,8 +1291,8 @@ int bdrv_reopen_prepare(BDRVReopenState *reopen_state,
BlockReopenQueue *queue,
if (local_err != NULL) {
error_propagate(errp, local_err);
} else {
- error_set(errp, QERR_OPEN_FILE_FAILED,
- reopen_state->bs->filename);
+ error_setg(errp, "failed while preparing to reopen image '%s'",
+ reopen_state->bs->filename);
}
goto error;
}
--
1.8.1.4
- [Qemu-devel] [PULL 0/9] QMP queue, Luiz Capitulino, 2013/06/17
- [Qemu-devel] [PULL 2/9] rng-random: use error_setg_file_open(), Luiz Capitulino, 2013/06/17
- [Qemu-devel] [PULL 3/9] block: mirror_complete(): use error_setg_file_open(), Luiz Capitulino, 2013/06/17
- [Qemu-devel] [PULL 4/9] blockdev: use error_setg_file_open(), Luiz Capitulino, 2013/06/17
- [Qemu-devel] [PULL 5/9] cpus: use error_setg_file_open(), Luiz Capitulino, 2013/06/17
- [Qemu-devel] [PULL 1/9] error: add error_setg_file_open() helper, Luiz Capitulino, 2013/06/17
- [Qemu-devel] [PULL 6/9] dump: qmp_dump_guest_memory(): use error_setg_file_open(), Luiz Capitulino, 2013/06/17
- [Qemu-devel] [PULL 9/9] qerror: drop QERR_OPEN_FILE_FAILED macro, Luiz Capitulino, 2013/06/17
- [Qemu-devel] [PULL 8/9] block: bdrv_reopen_prepare(): don't use QERR_OPEN_FILE_FAILED,
Luiz Capitulino <=
- [Qemu-devel] [PULL 7/9] savevm: qmp_xen_save_devices_state(): use error_setg_file_open(), Luiz Capitulino, 2013/06/17
- Re: [Qemu-devel] [PULL 0/9] QMP queue, Anthony Liguori, 2013/06/17