[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL 4/9] blockdev: use error_setg_file_open()
From: |
Luiz Capitulino |
Subject: |
[Qemu-devel] [PULL 4/9] blockdev: use error_setg_file_open() |
Date: |
Mon, 17 Jun 2013 11:57:06 -0400 |
Signed-off-by: Luiz Capitulino <address@hidden>
Reviewed-by: Stefan Hajnoczi <address@hidden>
Acked-by: Kevin Wolf <address@hidden>
---
blockdev.c | 11 +++++++----
1 file changed, 7 insertions(+), 4 deletions(-)
diff --git a/blockdev.c b/blockdev.c
index 9937311..5975dde 100644
--- a/blockdev.c
+++ b/blockdev.c
@@ -899,7 +899,7 @@ static void external_snapshot_prepare(BlkTransactionStates
*common,
ret = bdrv_open(states->new_bs, new_image_file, NULL,
flags | BDRV_O_NO_BACKING, drv);
if (ret != 0) {
- error_set(errp, QERR_OPEN_FILE_FAILED, new_image_file);
+ error_setg_file_open(errp, -ret, new_image_file);
}
}
@@ -1062,8 +1062,11 @@ static void qmp_bdrv_open_encrypted(BlockDriverState
*bs, const char *filename,
int bdrv_flags, BlockDriver *drv,
const char *password, Error **errp)
{
- if (bdrv_open(bs, filename, NULL, bdrv_flags, drv) < 0) {
- error_set(errp, QERR_OPEN_FILE_FAILED, filename);
+ int ret;
+
+ ret = bdrv_open(bs, filename, NULL, bdrv_flags, drv);
+ if (ret < 0) {
+ error_setg_file_open(errp, -ret, filename);
return;
}
@@ -1483,7 +1486,7 @@ void qmp_drive_mirror(const char *device, const char
*target,
if (ret < 0) {
bdrv_delete(target_bs);
- error_set(errp, QERR_OPEN_FILE_FAILED, target);
+ error_setg_file_open(errp, -ret, target);
return;
}
--
1.8.1.4
- [Qemu-devel] [PULL 0/9] QMP queue, Luiz Capitulino, 2013/06/17
- [Qemu-devel] [PULL 2/9] rng-random: use error_setg_file_open(), Luiz Capitulino, 2013/06/17
- [Qemu-devel] [PULL 3/9] block: mirror_complete(): use error_setg_file_open(), Luiz Capitulino, 2013/06/17
- [Qemu-devel] [PULL 4/9] blockdev: use error_setg_file_open(),
Luiz Capitulino <=
- [Qemu-devel] [PULL 5/9] cpus: use error_setg_file_open(), Luiz Capitulino, 2013/06/17
- [Qemu-devel] [PULL 1/9] error: add error_setg_file_open() helper, Luiz Capitulino, 2013/06/17
- [Qemu-devel] [PULL 6/9] dump: qmp_dump_guest_memory(): use error_setg_file_open(), Luiz Capitulino, 2013/06/17
- [Qemu-devel] [PULL 9/9] qerror: drop QERR_OPEN_FILE_FAILED macro, Luiz Capitulino, 2013/06/17
- [Qemu-devel] [PULL 8/9] block: bdrv_reopen_prepare(): don't use QERR_OPEN_FILE_FAILED, Luiz Capitulino, 2013/06/17
- [Qemu-devel] [PULL 7/9] savevm: qmp_xen_save_devices_state(): use error_setg_file_open(), Luiz Capitulino, 2013/06/17
- Re: [Qemu-devel] [PULL 0/9] QMP queue, Anthony Liguori, 2013/06/17