[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH trivial] vl: always define no_frame
From: |
Andreas Färber |
Subject: |
Re: [Qemu-devel] [PATCH trivial] vl: always define no_frame |
Date: |
Sun, 16 Jun 2013 19:26:46 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130510 Thunderbird/17.0.6 |
Am 15.06.2013 12:42, schrieb Michael Tokarev:
> Commit 047d4e151dd46 "Unbreak -no-quit for GTK, validate SDL options" broke
> build of qemu without sdl, by referencing `no_frame' variable which is defined
> inside #if SDL block. Fix that by defining that variable unconditionally.
>
> This is a better fix for the build issue introduced by that patch than
> a revert. This change keeps the new functinality introduced by that patch
> and just fixes the compilation. It still is not a complete fix around the
> original issue (not working -no-frame et al with -display gtk), because it
> makes only the legacy interface working, not the new suboption interface,
> so a few more changes are needed.
>
> Cc: Peter Wu <address@hidden>
> Cc: address@hidden
> Signed-off-by: Michael Tokarev <address@hidden>
Tested-by: Andreas Färber <address@hidden>
Unbreaks my headless ppc build.
Thanks,
Andreas
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg