qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v9 14/14] rdma: add pin-all accounting timestamp


From: Michael R. Hines
Subject: Re: [Qemu-devel] [PATCH v9 14/14] rdma: add pin-all accounting timestamp to QMP statistics
Date: Sun, 16 Jun 2013 00:06:32 -0400
User-agent: Mozilla/5.0 (X11; Linux i686; rv:17.0) Gecko/20130329 Thunderbird/17.0.5

On 06/15/2013 01:32 PM, Paolo Bonzini wrote:
Il 15/06/2013 05:06, Eric Blake ha scritto:
On 06/14/2013 09:35 PM, address@hidden wrote:
From: "Michael R. Hines" <address@hidden>

For very large virtual machines, pinning can take a long time.
While this does not affect the migration's *actual* time itself,
it is still important for the user to know what's going on and to
know what component of the total time is actual taken up by
pinning.

For example, using a 14GB virtual machine, pinning can take as
long as 5 seconds, for which the user would not otherwise know
what was happening.

Reviewed-by: Paolo Bonzini <address@hidden> Signed-off-by:
Michael R. Hines <address@hidden> ---
+++ b/qapi-schema.json @@ -586,7 +586,8 @@ '*xbzrle-cache':
'XBZRLECacheStats', '*total-time': 'int', '*expected-downtime':
'int', -           '*downtime': 'int'} } +           '*downtime':
'int', +           '*pin-all-time' : 'int'} }
Missing documentation of the new field (compare how @downtime is
documented as a (since 1.3) field).

Can you just time the setup phase instead?

Paolo


That's a great idea..... better to make it a more generic time.

I'll send out a V10 with everybody's suggestions.

- Michael




reply via email to

[Prev in Thread] Current Thread [Next in Thread]