Re: [Qemu-devel] [PATCH v9 14/14] rdma: add pin-all accounting timestamp to QMP statistics

[Paolo Bonzini]

Il 15/06/2013 05:06, Eric Blake ha scritto:
> On 06/14/2013 09:35 PM, address@hidden wrote:
>> From: "Michael R. Hines" <address@hidden>
>> 
>> For very large virtual machines, pinning can take a long time. 
>> While this does not affect the migration's *actual* time itself, 
>> it is still important for the user to know what's going on and to
>> know what component of the total time is actual taken up by 
>> pinning.
>> 
>> For example, using a 14GB virtual machine, pinning can take as 
>> long as 5 seconds, for which the user would not otherwise know 
>> what was happening.
>> 
>> Reviewed-by: Paolo Bonzini <address@hidden> Signed-off-by:
>> Michael R. Hines <address@hidden> ---
> 
>> +++ b/qapi-schema.json @@ -586,7 +586,8 @@ '*xbzrle-cache':
>> 'XBZRLECacheStats', '*total-time': 'int', '*expected-downtime':
>> 'int', -           '*downtime': 'int'} } +           '*downtime':
>> 'int', +           '*pin-all-time' : 'int'} }
> 
> Missing documentation of the new field (compare how @downtime is 
> documented as a (since 1.3) field).
> 

Can you just time the setup phase instead?

Paolo