Re: [Qemu-devel] [PATCH v2 0/5] configure: TARGET_ARCH cleanups

[Peter Maydell]

On 4 June 2013 13:45, Paolo Bonzini <address@hidden> wrote:
> We have three variables currently in config-target.h:
>
> - TARGET_ARCH is used to create a unique per-arch symbol, used in #ifdefs.
>   It is also used as a string through config-target.h, but this is almost
>   always wrong.
>
> - TARGET_ARCH2 is the name of the executable (minus the qemu-/qemu-system-
>   prefix); it is not available in config-target.h.
>
> - TARGET_TYPE is an enum but is otherwise the same as TARGET_ARCH2

Reviewed-by: Peter Maydell <address@hidden>

(PS: patch 5 here looks identical to patch 4 which got an r-by
from Eric Blake, but you don't seem to have carried that tag
forward; seems worth mentioning since that's the patch that
changes the qmp interface.)

thanks
-- PMM