[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH 18/26] Fix usage of USB_DEV_FLAG_IS_HOST flag.
From: |
Michael Roth |
Subject: |
[Qemu-devel] [PATCH 18/26] Fix usage of USB_DEV_FLAG_IS_HOST flag. |
Date: |
Wed, 12 Jun 2013 16:41:30 -0500 |
From: Michael Marineau <address@hidden>
USB_DEV_FLAG_IS_HOST is the bit number, not value. Booting with a
"Fitbit Base Station" USB dongle was triggering this assert.
Signed-off-by: Michael Marineau <address@hidden>
Cc: address@hidden
Signed-off-by: Gerd Hoffmann <address@hidden>
(cherry picked from commit 756335292f2b46775992c314cc70b54480a46d26)
Signed-off-by: Michael Roth <address@hidden>
---
hw/usb/core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/usb/core.c b/hw/usb/core.c
index 15a150a..05948ca 100644
--- a/hw/usb/core.c
+++ b/hw/usb/core.c
@@ -410,7 +410,7 @@ void usb_handle_packet(USBDevice *dev, USBPacket *p)
assert(p->ep->type != USB_ENDPOINT_XFER_ISOC);
/* using async for interrupt packets breaks migration */
assert(p->ep->type != USB_ENDPOINT_XFER_INT ||
- (dev->flags & USB_DEV_FLAG_IS_HOST));
+ (dev->flags & (1 << USB_DEV_FLAG_IS_HOST)));
usb_packet_set_state(p, USB_PACKET_ASYNC);
QTAILQ_INSERT_TAIL(&p->ep->queue, p, queue);
} else if (p->status == USB_RET_ADD_TO_QUEUE) {
--
1.7.9.5
- [Qemu-devel] [PATCH 08/26] chardev: fix "info chardev" output, (continued)
- [Qemu-devel] [PATCH 08/26] chardev: fix "info chardev" output, Michael Roth, 2013/06/12
- [Qemu-devel] [PATCH 09/26] ide: Set BSY bit during FLUSH, Michael Roth, 2013/06/12
- [Qemu-devel] [PATCH 10/26] Revert "roms: switch oldnoconfig to olddefconfig", Michael Roth, 2013/06/12
- [Qemu-devel] [PATCH 12/26] target-i386: fix abort on bad PML4E/PDPTE/PDE/PTE addresses, Michael Roth, 2013/06/12
- [Qemu-devel] [PATCH 13/26] Remove OSS support for OpenBSD, Michael Roth, 2013/06/12
- [Qemu-devel] [PATCH 14/26] xen: start PCI hole at 0xe0000000 (same as pc_init1 and qemu-xen-traditional), Michael Roth, 2013/06/12
- [Qemu-devel] [PATCH 11/26] update seabios to release 1.7.2.2, Michael Roth, 2013/06/12
- [Qemu-devel] [PATCH 15/26] do not check pointers after dereferencing them, Michael Roth, 2013/06/12
- [Qemu-devel] [PATCH 16/26] qdev: fix get_fw_dev_path to support to add nothing to fw_dev_path, Michael Roth, 2013/06/12
- [Qemu-devel] [PATCH 17/26] host-libusb: Correct test for USB packet state, Michael Roth, 2013/06/12
- [Qemu-devel] [PATCH 18/26] Fix usage of USB_DEV_FLAG_IS_HOST flag.,
Michael Roth <=
- [Qemu-devel] [PATCH 19/26] vmxnet3: fix NICState cleanup, Michael Roth, 2013/06/12
- [Qemu-devel] [PATCH 20/26] ui/gtk.c: Fix *BSD build of Gtk+ UI, Michael Roth, 2013/06/12
- [Qemu-devel] [PATCH 21/26] s390x/css: Fix concurrent sense., Michael Roth, 2013/06/12
- [Qemu-devel] [PATCH 22/26] virtio-ccw: Fix unsetting of indicators., Michael Roth, 2013/06/12
- [Qemu-devel] [PATCH 24/26] qemu-char: don't issue CHR_EVENT_OPEN in a BH, Michael Roth, 2013/06/12
- [Qemu-devel] [PATCH 25/26] target-i386: Fix aflag logic for CODE64 and the 0x67 prefix, Michael Roth, 2013/06/12
- [Qemu-devel] [PATCH 26/26] q35: set fw_name, Michael Roth, 2013/06/12
- [Qemu-devel] [PATCH 23/26] xilinx_axidma: Do not set DMA .notify to NULL after notify, Michael Roth, 2013/06/12
- Re: [Qemu-devel] Patch Round-up for stable 1.5.1, freeze on 2013-06-19, Stefan Hajnoczi, 2013/06/13
- Re: [Qemu-devel] Patch Round-up for stable 1.5.1, freeze on 2013-06-19, Paolo Bonzini, 2013/06/13