[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH qom-cpu v4 13/18] memory_mapping: Cleanup qemu_g

From: Andreas Färber
Subject: Re: [Qemu-devel] [PATCH qom-cpu v4 13/18] memory_mapping: Cleanup qemu_get_guest_memory_mapping()
Date: Tue, 11 Jun 2013 19:47:08 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130510 Thunderbird/17.0.6

Am 11.06.2013 17:52, schrieb Luiz Capitulino:
> On Sun,  9 Jun 2013 18:10:42 +0200
> Andreas Färber <address@hidden> wrote:
>> We relied on the CPUClass::get_memory_mapping() implementation being a
>> no-op when paging is disabled for that CPU. Therefore we can just as well
>> iterate over all CPUs to retrieve mappings.
>> This allows to use qemu_for_each_cpu() instead of open-coding CPU loops.
>> Pass any Error out into dump_init() and have it actually stop on errors.
>> Whether it is unsupported on a certain CPU can be checked by looking for
>> a NULL CPUClass::get_memory_mapping field.
>> Signed-off-by: Andreas Färber <address@hidden>
> Reviewed-by: Luiz Capitulino <address@hidden>

Thanks, reverted CPU loop changes and applied to qom-cpu as pure error
handling improvement:


SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg

reply via email to

[Prev in Thread] Current Thread [Next in Thread]