[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [Qemu-trivial] [PATCH] audio: Replace macro GCC_ATTR by

From: Stefan Weil
Subject: Re: [Qemu-devel] [Qemu-trivial] [PATCH] audio: Replace macro GCC_ATTR by GCC_FMT_ATTR and use inline functions
Date: Tue, 11 Jun 2013 19:24:04 +0200
User-agent: Mozilla/5.0 (X11; Linux i686; rv:17.0) Gecko/20130510 Thunderbird/17.0.6

Am 11.06.2013 14:38, schrieb Michael Tokarev:
> [Removing malc's email since it bounces]
> 09.06.2013 16:22, Stefan Weil wrote:
>> GCC_ATTR was only used in audio_int.h, so it is now unused and
>> the definition can be removed from compiler.h.
>> Signed-off-by: Stefan Weil <address@hidden>


> This change (adding `inline') causes build failure with at least with gcc-4.7:
> audio/wavaudio.c: In function ‘dolog’:
> audio/audio_int.h:246:100: error: function ‘dolog’ can never be inlined 
> because it uses variable argument lists
> $ gcc --version
> gcc (Debian 4.7.2-5) 4.7.2
> I think the addition of inline should be dropped here and in other
> similar places (the rest is ok).
> I can do that myself if you want.
> Alternatively these functions can be turned into varargs #defines.
> Thanks,
> /mjt

Thank you for reporting this compiler problem. I did not see
it because I configured with -enable-debugwhich disables
inline functions.

I'll send a new patch which uses macros.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]