[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 04/11] snapshot: new function bdrv_snapshot_find
From: |
Stefan Hajnoczi |
Subject: |
Re: [Qemu-devel] [PATCH 04/11] snapshot: new function bdrv_snapshot_find_by_id_and_name() |
Date: |
Tue, 11 Jun 2013 10:26:25 +0200 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
On Sat, Jun 08, 2013 at 02:58:00PM +0800, Wenchao Xia wrote:
> + if (id && name) {
> + for (i = 0; i < nb_sns; i++) {
> + sn = &sn_tab[i];
> + if (!strcmp(sn->id_str, id) && !strcmp(sn->name, name)) {
> + *sn_info = *sn;
> + ret = true;
> + break;
> + }
> + }
> + } else if (id) {
> + for (i = 0; i < nb_sns; i++) {
> + sn = &sn_tab[i];
> + if (!strcmp(sn->id_str, id)) {
> + *sn_info = *sn;
> + ret = true;
> + break;
> + }
> + }
> + } else if (name) {
> + for (i = 0; i < nb_sns; i++) {
> + sn = &sn_tab[i];
> + if (!strcmp(sn->name, name)) {
> + *sn_info = *sn;
> + ret = true;
> + break;
> + }
> + }
> + } else {
> + /* program error */
> + abort();
> + }
If you respin, this would be a little clearer:
assert(id || name);
if (id && name) {
...
} else if (id) {
...
} else if (name) {
...
}
The advantage is that the assert(3) condition is included in the error
message that gets printed.
Stefan
- [Qemu-devel] [PATCH 01/11] blockdev: drop redundant proto_drv check, (continued)
- Re: [Qemu-devel] [PATCH 04/11] snapshot: new function bdrv_snapshot_find_by_id_and_name(),
Stefan Hajnoczi <=
[Qemu-devel] [PATCH 06/11] snapshot: distinguish id and name in snapshot delete, Wenchao Xia, 2013/06/08
[Qemu-devel] [PATCH 07/11] qmp: add internal snapshot support in qmp_transaction, Wenchao Xia, 2013/06/08
[Qemu-devel] [PATCH 08/11] qmp: add interface blockdev-snapshot-internal-sync, Wenchao Xia, 2013/06/08
[Qemu-devel] [PATCH 09/11] qmp: add interface blockdev-snapshot-delete-internal-sync, Wenchao Xia, 2013/06/08