[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v4 0/9] Make 'dump-guest-memory' dump in kdump-c

From: Qiao Nuohan
Subject: Re: [Qemu-devel] [PATCH v4 0/9] Make 'dump-guest-memory' dump in kdump-compressed format
Date: Tue, 11 Jun 2013 09:48:40 +0800
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:10.0.5) Gecko/20120607 Thunderbird/10.0.5

On 06/10/2013 08:54 PM, Luiz Capitulino wrote:
On Mon, 10 Jun 2013 10:15:35 +0800
Qiao Nuohan<address@hidden>  wrote:

On 06/05/2013 10:15 AM, Luiz Capitulino wrote:
I can review it until the end of this week. If this series is adding a new
argument (which I believe is what it does) then there's only two ways
to get this merged: either we wait for full introspection or you add this
feature as a new command.

I'd prefer to wait for full introspection, but it depends how long it's
going to take to get it merged and how much time you're willing to wait.

Amos, can you give us an update on that work?

Hi Luiz,

I would like to get these patches reviewed first. If introspection won't take
too much time, I will choose to wait. However, I cannot figure out how long it
will take, why not get the parts not related to introspection settled first?

What do you mean by "settled"? We can keep the review cycle going, but to
merge this we have two options: we wait for the full introspection or we
make this a different command.

Sorry for confusing you. I mean "reviewed enough" here.

If it won't take several months, I have no doubt about waiting for
introspection. I just want these patches reviewed first, then I may get these
patches ready for merging soon after introspection support.

Seems Amos's draft will not change qapi-schema.json.

The point of Amos series is discovery, not conflicts. If we merge your
series w/o introspection support, then it's impossible for a mngt app like
libvirt to know whether or not a given QEMU version supports your new

Thanks for your explanation.

Qiao Nuohan

reply via email to

[Prev in Thread] Current Thread [Next in Thread]