[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH trivial] configure: explicitly disable virtfs if

From: Peter Maydell
Subject: Re: [Qemu-devel] [PATCH trivial] configure: explicitly disable virtfs if softmmu=no
Date: Mon, 10 Jun 2013 22:45:15 +0100

On 10 June 2013 21:47, Michael Tokarev <address@hidden> wrote:
> Or else
>  ./configure --disable-system --enable-virtfs
> (which makes no sense by its own but does not error out)
> will fail to build, because it will define CONFIG_VIRTFS,
> and the makefile will try to build virtfs-proxy-helper
> manpage (but not the executable).
> Cc: address@hidden
> Cc: M. Mohan Kumar <address@hidden>
> Signed-off-by: Michael Tokarev <address@hidden>
> ---
>  configure |    2 ++
>  1 file changed, 2 insertions(+)
> diff --git a/configure b/configure
> index a3f0b7a..0ff0380 100755
> --- a/configure
> +++ b/configure
> @@ -3423,6 +3423,8 @@ if test "$softmmu" = yes ; then
>        tools="qemu-ga\$(EXESUF) $tools"
>      fi
>    fi
> +else
> +  virtfs=no
>  fi

This doesn't feel to me like it's quite the right way
to fix this bug. The current code in configure seems
to tangle up (a) was virtfs requested and can we do it?
with (b) what do we need to do if it was? (build some
extra tools) and (c) when does it make sense? not for
linux-user targets. So you end up with an 'else virtfs=no'
clause added in an odd place. If the mess was untangled
then this probably wouldn't be necessary.

Also, disabling building tools and docs in general seems
broken: --disable-tools disables building qemu-img, for
instance, but not its documentation. So maybe we should
fix this by generally making sure we don't build the docs
unless we build the tool as well.

-- PMM

reply via email to

[Prev in Thread] Current Thread [Next in Thread]