Re: [Qemu-devel] [PATCH] curl: refuse to open URL from HTTP server without range support

[Stefan Hajnoczi]

On Sun, Jun 09, 2013 at 10:34:54AM +0800, Fam Zheng wrote:
> @@ -110,14 +111,14 @@ static int curl_sock_cb(CURL *curl, curl_socket_t fd, 
> int action,
>      return 0;
>  }
>  
> -static size_t curl_size_cb(void *ptr, size_t size, size_t nmemb, void 
> *opaque)
> +static size_t curl_header_cb(void *ptr, size_t size, size_t nmemb, void 
> *opaque)
>  {
> -    CURLState *s = ((CURLState*)opaque);
> +    BDRVCURLState *s = opaque;
>      size_t realsize = size * nmemb;
> -    size_t fsize;
> +    const char *accept_line = "Accept-Ranges: bytes";
>  
> -    if(sscanf(ptr, "Content-Length: %zd", &fsize) == 1) {
> -        s->s->len = fsize;
> +    if (strncmp((char *)ptr, accept_line, strlen(accept_line)) == 0) {
> +        s->accept_range = true;
>      }

This still assumes ptr is NUL-terminated.  You need to pass size * nmemb
instead of strlen(accept_line).