qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 08/16] qemu-io: Move 'help' function


From: Stefan Hajnoczi
Subject: Re: [Qemu-devel] [PATCH 08/16] qemu-io: Move 'help' function
Date: Wed, 5 Jun 2013 14:37:07 +0200
User-agent: Mutt/1.5.21 (2010-09-15)

On Tue, May 28, 2013 at 05:27:28PM +0200, Kevin Wolf wrote:
> No reason to treat it different from other commands. Move it to
> qemu-io-cmds.c, adapt the coding style and register it like any other
> command.
> 
> Signed-off-by: Kevin Wolf <address@hidden>
> ---
>  cmd.c          | 79 
> ----------------------------------------------------------
>  cmd.h          |  1 -
>  qemu-io-cmds.c | 67 ++++++++++++++++++++++++++++++++++++++++++++++++-
>  3 files changed, 66 insertions(+), 81 deletions(-)
> 
> diff --git a/cmd.c b/cmd.c
> index 7ae978f..2941ad3 100644
> --- a/cmd.c
> +++ b/cmd.c

'help' is a generic command, it's not specific to qemu-io.  IMO cmd.c is
the right place for it since other command-line tools might also need
'help'.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]