Re: [Qemu-devel] [PATCH 04/13] pseries: savevm support for XICS interrupt controller

[David Gibson]

On Wed, Jun 05, 2013 at 01:22:02PM +1000, Alexey Kardashevskiy wrote:
> On 06/04/2013 10:20 PM, Alexey Kardashevskiy wrote:
[snip]
> > +static int ics_post_load(void *opaque, int version_id)
> > +{
> > +    int i;
> > +    struct ics_state *ics = opaque;
> > +
> > +    for (i = 0; i < ics->nr_irqs; i++) {
> 
> Obviously here is a bug...
> 
> -    for (i = 0; i < ics->nr_irqs; i++) {
> +    for (i = 0; i < ics->icp->nr_servers; i++) {

Ah.. yes.  Although it would be a little nicer to avoid the duplicate
calls to ics_resend() that will cause.  Still the simple version
should be correct for now.  Please resend with this fixed.

-- 
David Gibson                    | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au  | minimalist, thank you.  NOT _the_ _other_
                                | _way_ _around_!
http://www.ozlabs.org/~dgibson

pgpuxyp33tb0K.pgp
Description: PGP signature