Re: [Qemu-devel] [PATCH 2/2] tcg: Remove redundant tcg_target_init checks

[li guang]

Reviewed-by: liguang <address@hidden>

在 2013-06-04二的 09:58 -0700，Richard Henderson写道：
> We've got a compile-time check for the condition in exec/cpu-defs.h.
> 
> Signed-off-by: Richard Henderson <address@hidden>
> ---
>  tcg/arm/tcg-target.c  | 6 ------
>  tcg/i386/tcg-target.c | 6 ------
>  tcg/s390/tcg-target.c | 7 -------
>  3 files changed, 19 deletions(-)
> 
> diff --git a/tcg/arm/tcg-target.c b/tcg/arm/tcg-target.c
> index 3d43412..6be736b 100644
> --- a/tcg/arm/tcg-target.c
> +++ b/tcg/arm/tcg-target.c
> @@ -2053,12 +2053,6 @@ static const TCGTargetOpDef arm_op_defs[] = {
>  
>  static void tcg_target_init(TCGContext *s)
>  {
> -#if !defined(CONFIG_USER_ONLY)
> -    /* fail safe */
> -    if ((1 << CPU_TLB_ENTRY_BITS) != sizeof(CPUTLBEntry))
> -        tcg_abort();
> -#endif
> -
>      tcg_regset_set32(tcg_target_available_regs[TCG_TYPE_I32], 0, 0xffff);
>      tcg_regset_set32(tcg_target_call_clobber_regs, 0,
>                       (1 << TCG_REG_R0) |
> diff --git a/tcg/i386/tcg-target.c b/tcg/i386/tcg-target.c
> index 9eec06c..9e95477 100644
> --- a/tcg/i386/tcg-target.c
> +++ b/tcg/i386/tcg-target.c
> @@ -2283,12 +2283,6 @@ static void tcg_target_init(TCGContext *s)
>      }
>  #endif
>  
> -#if !defined(CONFIG_USER_ONLY)
> -    /* fail safe */
> -    if ((1 << CPU_TLB_ENTRY_BITS) != sizeof(CPUTLBEntry))
> -        tcg_abort();
> -#endif
> -
>      if (TCG_TARGET_REG_BITS == 64) {
>          tcg_regset_set32(tcg_target_available_regs[TCG_TYPE_I32], 0, 0xffff);
>          tcg_regset_set32(tcg_target_available_regs[TCG_TYPE_I64], 0, 0xffff);
> diff --git a/tcg/s390/tcg-target.c b/tcg/s390/tcg-target.c
> index 7d6f777..f229f1c 100644
> --- a/tcg/s390/tcg-target.c
> +++ b/tcg/s390/tcg-target.c
> @@ -2324,13 +2324,6 @@ static void query_facilities(void)
>  
>  static void tcg_target_init(TCGContext *s)
>  {
> -#if !defined(CONFIG_USER_ONLY)
> -    /* fail safe */
> -    if ((1 << CPU_TLB_ENTRY_BITS) != sizeof(CPUTLBEntry)) {
> -        tcg_abort();
> -    }
> -#endif
> -
>      query_facilities();
>  
>      tcg_regset_set32(tcg_target_available_regs[TCG_TYPE_I32], 0, 0xffff);