[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v5 3/4] Add i.MX25 3DS evaluation board support.
From: |
Peter Maydell |
Subject: |
Re: [Qemu-devel] [PATCH v5 3/4] Add i.MX25 3DS evaluation board support. |
Date: |
Mon, 3 Jun 2013 16:18:35 +0100 |
On 8 May 2013 09:28, Jean-Christophe DUBOIS <address@hidden> wrote:
> For now we support:
> * timers (GPT and EPIT)
> * serial ports
> * ethernet (through the newly added FEC emulator)
> * I2C (through the newly added I2C emulator)
> + /* add I2C 0 */
> + i2c_dev = sysbus_create_simple("imx.i2c", 0x43f80000,
> + qdev_get_gpio_in(pic_dev, 3));
> + /*
> + * this I2C device doesn't exits on the real board.
"exist"
> + * We add it to be able to do a bit of simple qtest.
> + * see "make check" for details
> + */
> + i2c_create_slave((i2c_bus *)qdev_get_child_bus(i2c_dev, "i2c"),
> + "ds1338", 0x68);
If it doesn't exist on the real board we shouldn't create it
in the model (except possibly under an "if qtest" guard).
"if qtest" guards are pretty ugly though.
> +
> + /* add I2C 1 */
> + sysbus_create_simple("imx.i2c", 0x43f98000, qdev_get_gpio_in(pic_dev,
> 4));
> + /* add I2C 2 */
> + sysbus_create_simple("imx.i2c", 0x43f84000, qdev_get_gpio_in(pic_dev,
> 10));
> +
> + imx25_3ds_binfo.ram_size = ram_size;
> + imx25_3ds_binfo.kernel_filename = kernel_filename;
> + imx25_3ds_binfo.kernel_cmdline = kernel_cmdline;
> + imx25_3ds_binfo.initrd_filename = initrd_filename;
> + imx25_3ds_binfo.nb_cpus = 1;
> +
> + /*
> + * We test explicitely for qtest here as it is not done (yet?) in
"explicitly".
> + * arm_load_kernel(). Without this the "make check" command would
> + * fail.
> + */
> + if (!qtest_enabled()) {
> + arm_load_kernel(cpu, &imx25_3ds_binfo);
> + }
> +}
thanks
-- PMM
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- Re: [Qemu-devel] [PATCH v5 3/4] Add i.MX25 3DS evaluation board support.,
Peter Maydell <=