Re: [Qemu-devel] [PATCH] tcx: Fix 24-bit display mode

[Mark Cave-Ayland]

On 01/06/13 21:59, Blue Swirl wrote:

> On Sat, Jun 1, 2013 at 11:41 AM, Mark Cave-Ayland
> <address@hidden>  wrote:
> > Commit d08151bf (conversion of tcx to the memory API) broke the 24-bit mode of
> > the tcx display adapter by accidentally passing in the final address of the
> > dirty region to memory_region_reset_dirty() instead of its size.
> >
> > Signed-off-by: Mark Cave-Ayland<address@hidden>
>
> Patch looks OK, but please wrap the lines:
> WARNING: line over 80 characters
> #81: FILE: hw/display/tcx.c:196:
> +                              page_min, (page_max - page_min) +
> TARGET_PAGE_SIZE,
>
> WARNING: line over 80 characters
> #100: FILE: hw/display/tcx.c:288:
> +                                  page_min, (page_max - page_min) +
> TARGET_PAGE_SIZE,
>
> total: 0 errors, 2 warnings, 26 lines checked

Thanks for the pointers - I'll resubmit a tidied-up v2 patch shortly.


ATB,

Mark.