[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v5 01/11] notify: add NotiferWithReturn so notifier
From: |
Stefan Hajnoczi |
Subject: |
[Qemu-devel] [PATCH v5 01/11] notify: add NotiferWithReturn so notifier list can abort |
Date: |
Thu, 30 May 2013 14:34:49 +0200 |
notifier_list_notify() has no return value. This is fine when we just
want to invoke side-effects.
Sometimes it's useful for notifiers to produce a return value. This
allows notifiers to "veto" an operation and will be used by the block
layer before-write notifier.
Signed-off-by: Stefan Hajnoczi <address@hidden>
---
include/qemu/notify.h | 25 +++++++++++++++++++++++++
util/notify.c | 30 ++++++++++++++++++++++++++++++
2 files changed, 55 insertions(+)
diff --git a/include/qemu/notify.h b/include/qemu/notify.h
index 4e2e7f0..d3103e7 100644
--- a/include/qemu/notify.h
+++ b/include/qemu/notify.h
@@ -40,4 +40,29 @@ void notifier_remove(Notifier *notifier);
void notifier_list_notify(NotifierList *list, void *data);
+/* Same as Notifier but allows .notify() to return errors */
+typedef struct NotifierWithReturn NotifierWithReturn;
+
+struct NotifierWithReturn {
+ int (*notify)(NotifierWithReturn *notifier, void *data);
+ QLIST_ENTRY(NotifierWithReturn) node;
+};
+
+typedef struct NotifierWithReturnList {
+ QLIST_HEAD(, NotifierWithReturn) notifiers;
+} NotifierWithReturnList;
+
+#define NOTIFIER_WITH_RETURN_LIST_INITIALIZER(head) \
+ { QLIST_HEAD_INITIALIZER((head).notifiers) }
+
+void notifier_with_return_list_init(NotifierWithReturnList *list);
+
+void notifier_with_return_list_add(NotifierWithReturnList *list,
+ NotifierWithReturn *notifier);
+
+void notifier_with_return_remove(NotifierWithReturn *notifier);
+
+int notifier_with_return_list_notify(NotifierWithReturnList *list,
+ void *data);
+
#endif
diff --git a/util/notify.c b/util/notify.c
index 7b7692a..f215dfc 100644
--- a/util/notify.c
+++ b/util/notify.c
@@ -39,3 +39,33 @@ void notifier_list_notify(NotifierList *list, void *data)
notifier->notify(notifier, data);
}
}
+
+void notifier_with_return_list_init(NotifierWithReturnList *list)
+{
+ QLIST_INIT(&list->notifiers);
+}
+
+void notifier_with_return_list_add(NotifierWithReturnList *list,
+ NotifierWithReturn *notifier)
+{
+ QLIST_INSERT_HEAD(&list->notifiers, notifier, node);
+}
+
+void notifier_with_return_remove(NotifierWithReturn *notifier)
+{
+ QLIST_REMOVE(notifier, node);
+}
+
+int notifier_with_return_list_notify(NotifierWithReturnList *list, void *data)
+{
+ NotifierWithReturn *notifier, *next;
+ int ret = 0;
+
+ QLIST_FOREACH_SAFE(notifier, &list->notifiers, node, next) {
+ ret = notifier->notify(notifier, data);
+ if (ret != 0) {
+ break;
+ }
+ }
+ return ret;
+}
--
1.8.1.4
- [Qemu-devel] [PATCH v5 10/11] blockdev: add Abort transaction, (continued)
- [Qemu-devel] [PATCH v5 10/11] blockdev: add Abort transaction, Stefan Hajnoczi, 2013/05/30
- [Qemu-devel] [PATCH v5 04/11] blockdev: drop redundant proto_drv check, Stefan Hajnoczi, 2013/05/30
- [Qemu-devel] [PATCH v5 07/11] blockdev: rename BlkTransactionStates to singular, Stefan Hajnoczi, 2013/05/30
- [Qemu-devel] [PATCH v5 05/11] blockdev: use bdrv_getlength() in qmp_drive_mirror(), Stefan Hajnoczi, 2013/05/30
- [Qemu-devel] [PATCH v5 02/11] block: add bdrv_add_before_write_notifier(), Stefan Hajnoczi, 2013/05/30
- [Qemu-devel] [PATCH v5 11/11] qemu-iotests: add 055 drive-backup test case, Stefan Hajnoczi, 2013/05/30
- [Qemu-devel] [PATCH v5 01/11] notify: add NotiferWithReturn so notifier list can abort,
Stefan Hajnoczi <=
- [Qemu-devel] [PATCH v5 06/11] block: add drive-backup QMP command, Stefan Hajnoczi, 2013/05/30
- [Qemu-devel] [PATCH v5 03/11] block: add basic backup support to block driver, Stefan Hajnoczi, 2013/05/30