[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [SeaBIOS PATCH] boot: fix fw_dev_path pattern for q35-p
From: |
Kevin O'Connor |
Subject: |
Re: [Qemu-devel] [SeaBIOS PATCH] boot: fix fw_dev_path pattern for q35-pcihost |
Date: |
Tue, 28 May 2013 18:59:02 -0400 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
On Tue, May 28, 2013 at 08:28:14PM +0800, Amos Kong wrote:
> Bootindex string passed from qemu:
> /address@hidden/address@hidden/address@hidden
>
> We match pci domain by "/address@hidden" in SeaBIOS, but fw_dev_path prefix
> of q35 is "/address@hidden". So bootindex in qemu commandline
> doesn't work if it uses q35 machine type.
>
> This patch fixes the pattern to match both original pc-i440fx & q35
>
> Signed-off-by: Amos Kong <address@hidden>
> ---
> src/boot.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/boot.c b/src/boot.c
> index cd9d784..f30d47e 100644
> --- a/src/boot.c
> +++ b/src/boot.c
> @@ -97,7 +97,7 @@ find_prio(const char *glob)
> return -1;
> }
>
> -#define FW_PCI_DOMAIN "/address@hidden"
> +#define FW_PCI_DOMAIN "/address@hidden"
The seabios pattern matching code isn't that sophisticated - I think
this could end up doing something unexpected. Why does it need to
change?
-Kevin