[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 05/16] qemu-io: Don't use global bs in command i
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH 05/16] qemu-io: Don't use global bs in command implementations |
Date: |
Tue, 28 May 2013 11:02:11 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130514 Thunderbird/17.0.6 |
On 05/28/2013 09:37 AM, Kevin Wolf wrote:
> Am 28.05.2013 um 17:27 hat Kevin Wolf geschrieben:
>> Pass in the BlockDriverState to the command handlers instead of using
>> the global variable. This is an important step to make the commands
>> usable outside of qemu-io.
>>
>> Signed-off-by: Kevin Wolf <address@hidden>
>
>> @@ -1793,7 +1808,7 @@ static const cmdinfo_t abort_cmd = {
>> .oneline = "simulate a program crash using abort(3)",
>> };
>>
>> -static int close_f(int argc, char **argv)
>> +static int close_f(BlockDriverState *bs, int argc, char **argv)
>> {
>> bdrv_delete(bs);
>> bs = NULL;
>
> Here I missed the following hunk that I've applied locally now:
>
> --- a/qemu-io.c
> +++ b/qemu-io.c
> @@ -1811,7 +1811,7 @@ static const cmdinfo_t abort_cmd = {
> static int close_f(BlockDriverState *bs, int argc, char **argv)
> {
> bdrv_delete(bs);
> - bs = NULL;
> + qemuio_bs = NULL;
Reviewed-by: Eric Blake <address@hidden>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [PATCH 01/16] qemu-io: Remove unused args_command, (continued)
- [Qemu-devel] [PATCH 01/16] qemu-io: Remove unused args_command, Kevin Wolf, 2013/05/28
- [Qemu-devel] [PATCH 02/16] cutils: Support 'P' and 'E' suffixes in strtosz(), Kevin Wolf, 2013/05/28
- [Qemu-devel] [PATCH 03/16] qemu-io: Make cvtnum() a wrapper around strtosz_suffix(), Kevin Wolf, 2013/05/28
- [Qemu-devel] [PATCH 04/16] qemu-io: Handle cvtnum() errors in 'alloc', Kevin Wolf, 2013/05/28
- [Qemu-devel] [PATCH 05/16] qemu-io: Don't use global bs in command implementations, Kevin Wolf, 2013/05/28
- [Qemu-devel] [PATCH 08/16] qemu-io: Move 'help' function, Kevin Wolf, 2013/05/28
- [Qemu-devel] [PATCH 07/16] qemu-io: Factor out qemuio_command, Kevin Wolf, 2013/05/28
- [Qemu-devel] [PATCH 09/16] qemu-io: Move 'quit' function, Kevin Wolf, 2013/05/28
- [Qemu-devel] [PATCH 06/16] qemu-io: Split off commands to qemu-io-cmds.c, Kevin Wolf, 2013/05/28
- [Qemu-devel] [PATCH 10/16] qemu-io: Move qemu_strsep() to cutils.c, Kevin Wolf, 2013/05/28