[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH V3 4/4] block: dump snapshot and image info to s
From: |
Kevin Wolf |
Subject: |
Re: [Qemu-devel] [PATCH V3 4/4] block: dump snapshot and image info to specified output |
Date: |
Mon, 27 May 2013 17:40:59 +0200 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
Am 27.05.2013 um 17:02 hat Luiz Capitulino geschrieben:
> On Sat, 25 May 2013 11:09:45 +0800
> Wenchao Xia <address@hidden> wrote:
>
> > bdrv_snapshot_dump() and bdrv_image_info_dump() do not dump to a buffer now,
> > some internal buffers are still used for format control, which have no
> > chance to be truncated. As a result, these two functions have no more issue
> > of truncation, and they can be used by both qemu and qemu-img with correct
> > parameter specified.
> >
> > Signed-off-by: Wenchao Xia <address@hidden>
>
> I don't like the casting and the void pointers very much, but I can't
> suggest anything better:
Maybe introduce and use a different function pointer type that
explicitly takes void* instead of FILE*. You'd still have to cast the
function pointers (and now actually in all instances), but then at least
nobody can accidentally misinterpret a Monitor* as FILE*.
Kevin
- Re: [Qemu-devel] [PATCH V3 1/4] block: drop bs_snapshots global variable, (continued)
- Re: [Qemu-devel] [PATCH V3 1/4] block: drop bs_snapshots global variable, Wenchao Xia, 2013/05/27
- Re: [Qemu-devel] [PATCH V3 1/4] block: drop bs_snapshots global variable, Stefan Hajnoczi, 2013/05/28
- Re: [Qemu-devel] [PATCH V3 1/4] block: drop bs_snapshots global variable, Wenchao Xia, 2013/05/29
- Re: [Qemu-devel] [PATCH V3 1/4] block: drop bs_snapshots global variable, Stefan Hajnoczi, 2013/05/29
- Re: [Qemu-devel] [PATCH V3 1/4] block: drop bs_snapshots global variable, Wenchao Xia, 2013/05/29
[Qemu-devel] [PATCH V3 2/4] block: move snapshot code in block.c to block/snapshot.c, Wenchao Xia, 2013/05/24
[Qemu-devel] [PATCH V3 4/4] block: dump snapshot and image info to specified output, Wenchao Xia, 2013/05/24
[Qemu-devel] [PATCH V3 3/4] block: move qmp and info dump related code to block/qapi.c, Wenchao Xia, 2013/05/24
Re: [Qemu-devel] [PATCH V3 0/4] qapi and snapshot code clean up in block layer, Kevin Wolf, 2013/05/27