Re: [Qemu-devel] [Qemu-trivial] [PATCH 0/4] debugcon: fix some bugs when DEBUG_DEBUGCON

[Michael Tokarev]

25.05.2013 14:35, Andreas Färber wrote:
> Am 25.05.2013 11:28, schrieb Michael Tokarev:
[]
>>>      debugcon: use fprintf(stderr...) instead of printf
>>
>> The subjects and commit messages are a bit inaccurate, and
>> as Andreas says, these may have been merged together, but
>> the inaccuracy is small (and mostly due to language barriers),
>> and the result is good anyway, with one patch doing one thing.
>>
>> So.. thanks, applied to the trivial-patches queue.
> 
> NACK. If you want to apply 1-3, okay. But please unqueue 4/4, it makes
> no sense as-is (just look at the stderr output to see what I mean) and
> it pretends that I suggested that!

Actually I did just that, rebuild with DEBUG_DEBUGCON and looked
at the output, -- because I didn't know how it works.  And you're
right, it's not a good change ;)  But your email come before I was
able to reply.  Unqueued.

Thank you for noticing this.

/mjt