[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v5 05/11] curl: add timer to BDRVCURLState
From: |
Fam Zheng |
Subject: |
Re: [Qemu-devel] [PATCH v5 05/11] curl: add timer to BDRVCURLState |
Date: |
Fri, 24 May 2013 10:59:50 +0800 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
On Thu, 05/23 15:55, Stefan Hajnoczi wrote:
> On Thu, May 23, 2013 at 11:38:03AM +0800, Fam Zheng wrote:
> > diff --git a/block/curl.c b/block/curl.c
> > index fc464ad..4fd5bb9 100644
> > --- a/block/curl.c
> > +++ b/block/curl.c
> > @@ -89,6 +89,7 @@ typedef struct BDRVCURLState {
> > QLIST_HEAD(, CURLSockInfo) socks;
> > char *url;
> > size_t readahead_size;
> > + QEMUTimer *timer;
> > /* Whether http server accept range in header */
> > bool accept_range;
> > } BDRVCURLState;
> > @@ -148,6 +149,38 @@ static size_t curl_header_cb(void *ptr, size_t size,
> > size_t nmemb, void *opaque)
> > return realsize;
> > }
> >
> > +static void curl_timer_cb(void *opaque)
> > +{
> > + int running;
> > + BDRVCURLState *bs = (BDRVCURLState *)opaque;
>
> Please call it 's'. 'bs' is for BlockDriverState*.
>
> Also, there is no need to cast void* to BDRVCURLState*, the conversion
> is implicit.
>
> > + DPRINTF("curl timeout!\n");
> > + curl_multi_socket_action(bs->multi, CURL_SOCKET_TIMEOUT, 0, &running);
> > +}
> > +
> > +/* Call back for curl_multi interface */
> > +static int curl_multi_timer_cb(CURLM *multi, long timeout_ms, void *s)
> > +{
> > + BDRVCURLState *bs = (BDRVCURLState *)s;
>
> Same here.
>
OK.
--
Fam
- [Qemu-devel] [PATCH v5 00/11] curl: fix curl read, Fam Zheng, 2013/05/22
- [Qemu-devel] [PATCH v5 01/11] curl: introduce CURLSockInfo to BDRVCURLState., Fam Zheng, 2013/05/22
- [Qemu-devel] [PATCH v5 02/11] curl: change magic number to sizeof, Fam Zheng, 2013/05/22
- [Qemu-devel] [PATCH v5 03/11] curl: change curl_multi_do to curl_fd_handler, Fam Zheng, 2013/05/22
- [Qemu-devel] [PATCH v5 04/11] curl: fix curl_open, Fam Zheng, 2013/05/22
- [Qemu-devel] [PATCH v5 05/11] curl: add timer to BDRVCURLState, Fam Zheng, 2013/05/22
- [Qemu-devel] [PATCH v5 06/11] curl: introduce CURLDataCache, Fam Zheng, 2013/05/22
- [Qemu-devel] [PATCH v5 07/11] curl: make use of CURLDataCache., Fam Zheng, 2013/05/22
- [Qemu-devel] [PATCH v5 08/11] curl: use list to store CURLState, Fam Zheng, 2013/05/22