[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [0/8] Clean up PCI code to allow for multiple root buse
From: |
Michael S. Tsirkin |
Subject: |
Re: [Qemu-devel] [0/8] Clean up PCI code to allow for multiple root buses |
Date: |
Thu, 23 May 2013 14:12:38 +0300 |
On Thu, May 09, 2013 at 10:31:04AM +1000, David Gibson wrote:
> The current PCI subsystem has kind of half-hearted support for
> multiple independent root buses - aka PCI domains - in the form of the
> PCIHostBus structure and its domain field. However, it doesn't quite
> work because pci_host_bus_register() is always called with a domain of
> 0.
>
> Worse, though, the whole concept of numbered domains isn't general
> enough. Many platforms can have independent root buses (usually on
> wholly independent host bridges), but only x86 gives them a
> hardware-significant domain number, essentially as a hack to allow all
> the separate config spaces to be accessed via the same IO ports.
> Linux guests on other platforms will show domain numbers in lspci, but
> these are purely guest assigned, so qemu won't know about them.
>
> This patch series, therefore, removes the broken-as-is domain concept
> from qemu, and replaces it with a different way of handling multiple
> root buses, based on a host bridge class method to provide a
> identifier for the root bus. This hook is designed in such a way as
> to allow a single bridge object to support mutiple root buses with
> future changes, which will allow future implementations of x86 north
> bridges with multiple domains to be supported correctly, and in way
> that matches the existing practice for all external interfaces.
I agree with the direction this patchset takes.
I sent some comments on the individual patches separately.
Thanks!
--
MST
- [Qemu-devel] [PATCH 4/8] pci: Use helper o find device's root bus in pci_find_domain(), (continued)
- [Qemu-devel] [PATCH 4/8] pci: Use helper o find device's root bus in pci_find_domain(), David Gibson, 2013/05/08
- [Qemu-devel] [PATCH 3/8] pci: Abolish pci_find_root_bus(), David Gibson, 2013/05/08
- [Qemu-devel] [PATCH 7/8] pci: Remove domain from PCIHostBus, David Gibson, 2013/05/08
- [Qemu-devel] [PATCH 8/8] pci: Fold host_buses list into PCIHostState functionality, David Gibson, 2013/05/08
- [Qemu-devel] [PATCH 5/8] pci: Replace pci_find_domain() with more general pci_root_bus_path(), David Gibson, 2013/05/08
- [Qemu-devel] [PATCH 1/8] pci: Cleanup configuration for pci-hotplug.c, David Gibson, 2013/05/08
- Re: [Qemu-devel] [0/8] Clean up PCI code to allow for multiple root buses, Michael S. Tsirkin, 2013/05/14
- Re: [Qemu-devel] [0/8] Clean up PCI code to allow for multiple root buses,
Michael S. Tsirkin <=