Re: [Qemu-devel] [PATCH v4 0/8] block: drive-backup live backup command

[Kevin Wolf]

Am 16.05.2013 um 10:36 hat Stefan Hajnoczi geschrieben:
> Note: These patches apply to my block-next tree.  You can also grab the code
> from git here:
> git://github.com/stefanha/qemu.git block-backup-core
> 
> This series adds a new QMP command, drive-backup, which takes a point-in-time
> snapshot of a block device.  The snapshot is copied out to a target block
> device.  A simple example is:
> 
>   drive-backup device=virtio0 format=qcow2 target=backup-20130401.qcow2

> Dietmar Maurer (1):
>   block: add basic backup support to block driver
> 
> Stefan Hajnoczi (7):
>   block: add bdrv_add_before_write_notifier()
>   block: add drive-backup QMP command
>   qemu-iotests: add 055 drive-backup test case
>   blockdev: rename BlkTransactionStates to singular
>   blockdev: add DriveBackup transaction
>   blockdev: add Abort transaction
>   qemu-iotests: test 'drive-backup' transaction in 055
> 
>  block.c                    |  18 ++-
>  block/Makefile.objs        |   1 +
>  block/backup.c             | 283 ++++++++++++++++++++++++++++++++++++
>  blockdev.c                 | 264 +++++++++++++++++++++++++++-------
>  include/block/block_int.h  |  38 ++++-
>  qapi-schema.json           |  69 ++++++++-
>  qmp-commands.hx            |  37 +++++
>  tests/qemu-iotests/055     | 348 
> +++++++++++++++++++++++++++++++++++++++++++++
>  tests/qemu-iotests/055.out |   5 +
>  tests/qemu-iotests/group   |   1 +
>  10 files changed, 1000 insertions(+), 64 deletions(-)
>  create mode 100644 block/backup.c
>  create mode 100755 tests/qemu-iotests/055
>  create mode 100644 tests/qemu-iotests/055.out

Commented on patches 2, 3 and 4. The others are:

Reviewed-by: Kevin Wolf <address@hidden>