[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [RFC 2/2] qemu-log: Interrupt the GDB session on guest-
From: |
Peter Maydell |
Subject: |
Re: [Qemu-devel] [RFC 2/2] qemu-log: Interrupt the GDB session on guest-errors |
Date: |
Wed, 22 May 2013 11:45:46 +0100 |
On 22 May 2013 11:38, <address@hidden> wrote:
> From: "Edgar E. Iglesias" <address@hidden>
> @@ -45,6 +46,25 @@ void qemu_log_mask(int mask, const char *fmt, ...)
> vfprintf(qemu_logfile, fmt, ap);
> }
> va_end(ap);
> +
> + /*
> + * Break the GDB session (if connected) so that the user can inspect the
> + * guest state.
> + *
> + * TODO: Consider conditionalizing this on a cmdline option.
> + */
This is definitely way too intrusive to be unconditional -- it can
happen really frequently (for instance Linux on OMAP3 will access
a nonexistent register every time it takes an interrupt).
thanks
-- PMM