[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] makefile: detect corrupted elf files
From: |
Markus Armbruster |
Subject: |
Re: [Qemu-devel] [PATCH] makefile: detect corrupted elf files |
Date: |
Wed, 22 May 2013 09:44:04 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.1 (gnu/linux) |
"Michael S. Tsirkin" <address@hidden> writes:
> On Tue, May 21, 2013 at 11:01:05PM +0100, Peter Maydell wrote:
>> On 21 May 2013 22:46, Michael S. Tsirkin <address@hidden> wrote:
>> > Once in a while make gets killed and doesn't
>> > clean up partial object files after it.
>> > Result is nasty errors from link.
>> > This hack checks object is well formed before linking,
>> > and rebuilds it if not.
>> >
>> > Signed-off-by: Michael S. Tsirkin <address@hidden>
>> > ---
>> >
>> > Is below useful for others?
>>
>> Seems to me like this is just working around a make bug:
>> it is supposed to delete the partial object if it gets
>> killed.
>
> It can't if it gets killed by kill -9 or e.g. OOM killer
> (or OS reboot).
Any generated file could be truncated then, not just objects.
If you abort a build with kill -9 or equivalent, you blow away the build
tree and start over. A sufficiently unlucky truncation could still
build, but not work.
[...]
- [Qemu-devel] [PATCH] makefile: detect corrupted elf files, Michael S. Tsirkin, 2013/05/21
- Re: [Qemu-devel] [PATCH] makefile: detect corrupted elf files, Peter Maydell, 2013/05/21
- Re: [Qemu-devel] [PATCH] makefile: detect corrupted elf files, Michael S. Tsirkin, 2013/05/21
- Re: [Qemu-devel] [PATCH] makefile: detect corrupted elf files,
Markus Armbruster <=
- Re: [Qemu-devel] [PATCH] makefile: detect corrupted elf files, Michael S. Tsirkin, 2013/05/22
- Re: [Qemu-devel] [PATCH] makefile: detect corrupted elf files, Peter Maydell, 2013/05/22
- Re: [Qemu-devel] [PATCH] makefile: detect corrupted elf files, Paolo Bonzini, 2013/05/22
- Re: [Qemu-devel] [PATCH] makefile: detect corrupted elf files, Michael S. Tsirkin, 2013/05/22
- Re: [Qemu-devel] [PATCH] makefile: detect corrupted elf files, Paolo Bonzini, 2013/05/22
- Re: [Qemu-devel] [PATCH] makefile: detect corrupted elf files, Michael S. Tsirkin, 2013/05/22
- Re: [Qemu-devel] [PATCH] makefile: detect corrupted elf files, Paolo Bonzini, 2013/05/22
- Re: [Qemu-devel] [PATCH] makefile: detect corrupted elf files, Michael S. Tsirkin, 2013/05/22
- Re: [Qemu-devel] [PATCH] makefile: detect corrupted elf files, Paolo Bonzini, 2013/05/22
- Re: [Qemu-devel] [PATCH] makefile: detect corrupted elf files, Michael S. Tsirkin, 2013/05/22