[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 14/30] memory: create FlatView for new address s
From: |
Peter Maydell |
Subject: |
Re: [Qemu-devel] [PATCH 14/30] memory: create FlatView for new address spaces |
Date: |
Tue, 21 May 2013 13:03:40 +0100 |
On 21 May 2013 11:57, Paolo Bonzini <address@hidden> wrote:
> Even a new address space might have a non-empty FlatView. In order
> to initialize it properly, address_space_init should (a) call
> memory_region_transaction_commit after the address space is inserted
> into the list; (b) force memory_region_transaction_commit to do something.
>
> This bug was latent so far because all address spaces started empty, including
> the PCI address space where the bus master region is initially disabled.
> However, the target address space of an IOMMU is usually rooted at
> get_system_memory(), which might not be empty at the time the IOMMU is
> created.
>
> Signed-off-by: Paolo Bonzini <address@hidden>
The patch title should probably be "populate FlatView for new address
spaces", not "create". Given that,
Reviewed-by: Peter Maydell <address@hidden>
-- PMM
- Re: [Qemu-devel] [PATCH 09/30] memory: do not duplicate memory_region_destructor_none, (continued)
- [Qemu-devel] [PATCH 10/30] memory: make memory_global_sync_dirty_bitmap take an AddressSpace, Paolo Bonzini, 2013/05/21
- [Qemu-devel] [PATCH 11/30] memory: fix address space initialization/destruction, Paolo Bonzini, 2013/05/21
- [Qemu-devel] [PATCH 12/30] s390x: reduce TARGET_PHYS_ADDR_SPACE_BITS to 62, Paolo Bonzini, 2013/05/21
- [Qemu-devel] [PATCH 13/30] memory: limit sections in the radix tree to the actual address space size, Paolo Bonzini, 2013/05/21
- [Qemu-devel] [PATCH 14/30] memory: create FlatView for new address spaces, Paolo Bonzini, 2013/05/21
- Re: [Qemu-devel] [PATCH 14/30] memory: create FlatView for new address spaces,
Peter Maydell <=
- [Qemu-devel] [PATCH 15/30] memory: add address_space_valid, Paolo Bonzini, 2013/05/21
- Re: [Qemu-devel] [PATCH 15/30] memory: add address_space_valid, Peter Maydell, 2013/05/23
- Re: [Qemu-devel] [PATCH 15/30] memory: add address_space_valid, Paolo Bonzini, 2013/05/24