qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v5] virtio-net: dynamic network offloads configu


From: Paolo Bonzini
Subject: Re: [Qemu-devel] [PATCH v5] virtio-net: dynamic network offloads configuration
Date: Mon, 20 May 2013 15:39:33 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130311 Thunderbird/17.0.4

Il 20/05/2013 15:36, Michael S. Tsirkin ha scritto:
> On Mon, May 20, 2013 at 12:52:57PM +0200, Paolo Bonzini wrote:
>> Il 20/05/2013 10:18, Michael S. Tsirkin ha scritto:
>>> diff --git a/include/hw/virtio/virtio-net.h b/include/hw/virtio/virtio-net.h
>>> index beeead7..b315ac9 100644
>>> --- a/include/hw/virtio/virtio-net.h
>>> +++ b/include/hw/virtio/virtio-net.h
>>> @@ -31,6 +31,8 @@
>>>  /* The feature bitmap for virtio net */
>>>  #define VIRTIO_NET_F_CSUM       0       /* Host handles pkts w/ partial 
>>> csum */
>>>  #define VIRTIO_NET_F_GUEST_CSUM 1       /* Guest handles pkts w/ partial 
>>> csum */
>>> +#define VIRTIO_NET_F_CTRL_GUEST_OFFLOADS 2 /* Control channel offload
>>> +                                         * configuration support */
>>
>> Any reason not to use 22?
> 
> There are several
> - 22 is already used by VIRTIO_NET_F_MQ

Oops, old copy here.

> - guest drivers (in development) and spec upstream both use 2
> 
> I don't know for sure, sorry.
> BTW please send questions on virtio spec on virtio
> mailing list, not here.

I could not find the message with the spec update, now I found it.  It
was a bit weird because the series had one patch for virtio-spec and one
for QEMU.

Paolo



reply via email to

[Prev in Thread] Current Thread [Next in Thread]