[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 01/12] add a header file for atomic operations
From: |
Peter Maydell |
Subject: |
Re: [Qemu-devel] [PATCH 01/12] add a header file for atomic operations |
Date: |
Wed, 15 May 2013 17:11:02 +0100 |
On 15 May 2013 16:48, Paolo Bonzini <address@hidden> wrote:
> We're already using them in several places, but __sync builtins are just
> too ugly to type, and do not provide seqcst load/store operations.
This doesn't compile:
CC tests/test-thread-pool.o
tests/test-thread-pool.c: In function ‘worker_cb’:
tests/test-thread-pool.c:20:34: error: macro "atomic_inc" passed 2
arguments, but takes just 1
tests/test-thread-pool.c:20:12: error: ‘atomic_inc’ undeclared (first
use in this function)
tests/test-thread-pool.c:20:12: note: each undeclared identifier is
reported only once for each function it appears in
tests/test-thread-pool.c:19:21: error: unused variable ‘data’
[-Werror=unused-variable]
tests/test-thread-pool.c: In function ‘long_cb’:
tests/test-thread-pool.c:26:27: error: macro "atomic_inc" passed 2
arguments, but takes just 1
tests/test-thread-pool.c:26:5: error: ‘atomic_inc’ undeclared (first
use in this function)
tests/test-thread-pool.c:28:27: error: macro "atomic_inc" passed 2
arguments, but takes just 1
tests/test-thread-pool.c:25:21: error: unused variable ‘data’
[-Werror=unused-variable]
tests/test-thread-pool.c: In function ‘worker_cb’:
tests/test-thread-pool.c:21:1: error: control reaches end of non-void
function [-Werror=return-type]
cc1: all warnings being treated as errors
thanks
-- PMM
- Re: [Qemu-devel] [PATCH 03/12] rcu: add rcu library, (continued)
- [Qemu-devel] [PATCH 04/12] qemu-thread: register threads with RCU, Paolo Bonzini, 2013/05/15
- [Qemu-devel] [PATCH 05/12] rcu: add call_rcu, Paolo Bonzini, 2013/05/15
- [Qemu-devel] [PATCH 06/12] rcu: add rcutorture, Paolo Bonzini, 2013/05/15
- [Qemu-devel] [PATCH 09/12] event loop: report RCU quiescent states, Paolo Bonzini, 2013/05/15
- [Qemu-devel] [PATCH 08/12] qemu-thread: report RCU quiescent states, Paolo Bonzini, 2013/05/15
- [Qemu-devel] [PATCH 10/12] cpus: report RCU quiescent states, Paolo Bonzini, 2013/05/15
- [Qemu-devel] [PATCH 01/12] add a header file for atomic operations, Paolo Bonzini, 2013/05/15
- Re: [Qemu-devel] [PATCH 01/12] add a header file for atomic operations,
Peter Maydell <=
- [Qemu-devel] [PATCH 11/12] block: report RCU quiescent states, Paolo Bonzini, 2013/05/15
- [Qemu-devel] [PATCH 12/12] migration: report RCU quiescent states, Paolo Bonzini, 2013/05/15
- [Qemu-devel] [PATCH 07/12] rcu: allow nested calls to rcu_thread_offline/rcu_thread_online, Paolo Bonzini, 2013/05/15
- Re: [Qemu-devel] [RFC PATCH 00/12] RCU implementation for QEMU, Peter Maydell, 2013/05/15
- Re: [Qemu-devel] [RFC PATCH 00/12] RCU implementation for QEMU, Peter Maydell, 2013/05/15
- Re: [Qemu-devel] [RFC PATCH 00/12] RCU implementation for QEMU, Peter Maydell, 2013/05/15