Re: [Qemu-devel] [PATCH 2/4] vnc: Support for LED state extension

[Laszlo Ersek]

On 05/15/13 08:05, Lei Li wrote:
> On 05/14/2013 07:35 PM, Gerd Hoffmann wrote:
>> On 04/25/13 07:29, Lei Li wrote:
>>> +    /* Sending the current led state message to the client */
>>> +    if (ledstate != current_led_state(vs)) {
>>> +        vnc_led_state_change(vs);
>>> +    }
>> This check never becomes true as the vnc modifier/led state just got
>> updated to match ledstate ...
> 
> Oh... then how about get rid of this check, let vnc_led_state_change send
> the current led state message directly?

You could do the comparison and save the result before updating the
modifiers array, and call vnc_led_state_change() in its current
location, dependent on the saved comparison result. Just my two cents.

Laszlo