Re: [Qemu-devel] [PATCH] fdt: update embedded header file from upstream to fix compilation

[Andre Przywara]

On 05/07/2013 03:24 PM, Peter Maydell wrote:
> On 7 May 2013 13:52, Andre Przywara <address@hidden> wrote:
> > On 05/07/2013 02:44 PM, Peter Maydell wrote:
> > > I'm not entirely sure I understand why we need change.
> > > Have upstream really introduced a breaking change for
> > > everybody who uses libfdt, or are we using it wrongly?
> >
> >
> > Everybody who copies and changes a header from the original distribution and
> > uses this now instead of the installed version ;-)
>
> Right, but the distro libfdt-dev package doesn't ship with
> libfdt_env.h, so presumably the expectation is that users
> of libfdt copy and adjust it, and so the set of things it
> has to provide is part of the "public" interface?

Seems to be true for the CentOS package for instance, but not for Wheezy:
http://packages.debian.org/wheezy/amd64/libfdt-dev/filelist

Also "make install" on the source distribution copies the file to 
/usr/include. Even if I delete it, fdt.h still references fdt32_t, so I 
get the same error again.

Regards,
Andre.