Re: [Qemu-devel] [PATCH 0/3] Fix memory migration for exynos 4210 SoC

[Peter Maydell]

On 10 March 2013 14:21, Igor Mitsyanko <address@hidden> wrote:
> First two patches fix issues in exynos4210 code which were blocking proper 
> memory
> migration.
>
> Third patch makes memory_region_init_ram_ptr assert if memory region size is 
> not a
> multiple of TARGET_PAGE_SIZE.
>
> Igor Mitsyanko (3):
>   hw/exynos4210.c: set chipid_and_omr array size to TARGET_PAGE_SIZE
>   exynos4210.c: register chipid_mem and rom_mem with vmstate
>   memory.c: only allow memory sizes which are a multiple of target page
>     size

I was talking to Paolo about this patchset on IRC, and we came to
the conclusion that for the chipid_and_omr bit the right solution
is not to misuse memory_region_init_ram_ptr() for this, but just
to implement it as a device with an mmio region.

We should probably still look at fixing the bugs with small
ramblocks and/or asserting if you try to create them, though.

thanks
-- PMM