[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [RFC][PATCH 02/15] applesmc: replace register_ioport*
From: |
Jan Kiszka |
Subject: |
[Qemu-devel] [RFC][PATCH 02/15] applesmc: replace register_ioport* |
Date: |
Mon, 6 May 2013 16:26:05 +0200 |
Convert over to memory regions to obsolete register_ioport*.
Signed-off-by: Jan Kiszka <address@hidden>
---
hw/misc/applesmc.c | 48 ++++++++++++++++++++++++++++++++++++------------
1 files changed, 36 insertions(+), 12 deletions(-)
diff --git a/hw/misc/applesmc.c b/hw/misc/applesmc.c
index 78904a8..af24be1 100644
--- a/hw/misc/applesmc.c
+++ b/hw/misc/applesmc.c
@@ -73,6 +73,8 @@ typedef struct AppleSMCState AppleSMCState;
struct AppleSMCState {
ISADevice parent_obj;
+ MemoryRegion io_data;
+ MemoryRegion io_cmd;
uint32_t iobase;
uint8_t cmd;
uint8_t status;
@@ -86,7 +88,8 @@ struct AppleSMCState {
QLIST_HEAD(, AppleSMCData) data_def;
};
-static void applesmc_io_cmd_writeb(void *opaque, uint32_t addr, uint32_t val)
+static void applesmc_io_cmd_write(void *opaque, hwaddr addr, uint64_t val,
+ unsigned size)
{
AppleSMCState *s = opaque;
@@ -115,7 +118,8 @@ static void applesmc_fill_data(AppleSMCState *s)
}
}
-static void applesmc_io_data_writeb(void *opaque, uint32_t addr, uint32_t val)
+static void applesmc_io_data_write(void *opaque, hwaddr addr, uint64_t val,
+ unsigned size)
{
AppleSMCState *s = opaque;
@@ -138,7 +142,8 @@ static void applesmc_io_data_writeb(void *opaque, uint32_t
addr, uint32_t val)
}
}
-static uint32_t applesmc_io_data_readb(void *opaque, uint32_t addr1)
+static uint64_t applesmc_io_data_read(void *opaque, hwaddr addr1,
+ unsigned size)
{
AppleSMCState *s = opaque;
uint8_t retval = 0;
@@ -162,7 +167,7 @@ static uint32_t applesmc_io_data_readb(void *opaque,
uint32_t addr1)
return retval;
}
-static uint32_t applesmc_io_cmd_readb(void *opaque, uint32_t addr1)
+static uint64_t applesmc_io_cmd_read(void *opaque, hwaddr addr1, unsigned size)
{
AppleSMCState *s = opaque;
@@ -201,18 +206,37 @@ static void qdev_applesmc_isa_reset(DeviceState *dev)
applesmc_add_key(s, "MSSD", 1, "\0x3");
}
+static const MemoryRegionOps applesmc_data_io_ops = {
+ .write = applesmc_io_data_write,
+ .read = applesmc_io_data_read,
+ .endianness = DEVICE_NATIVE_ENDIAN,
+ .impl = {
+ .min_access_size = 1,
+ .max_access_size = 1,
+ },
+};
+
+static const MemoryRegionOps applesmc_cmd_io_ops = {
+ .write = applesmc_io_cmd_write,
+ .read = applesmc_io_cmd_read,
+ .endianness = DEVICE_NATIVE_ENDIAN,
+ .impl = {
+ .min_access_size = 1,
+ .max_access_size = 1,
+ },
+};
+
static int applesmc_isa_init(ISADevice *dev)
{
AppleSMCState *s = APPLE_SMC(dev);
- register_ioport_read(s->iobase + APPLESMC_DATA_PORT, 4, 1,
- applesmc_io_data_readb, s);
- register_ioport_read(s->iobase + APPLESMC_CMD_PORT, 4, 1,
- applesmc_io_cmd_readb, s);
- register_ioport_write(s->iobase + APPLESMC_DATA_PORT, 4, 1,
- applesmc_io_data_writeb, s);
- register_ioport_write(s->iobase + APPLESMC_CMD_PORT, 4, 1,
- applesmc_io_cmd_writeb, s);
+ memory_region_init_io(&s->io_data, &applesmc_data_io_ops, s,
+ "applesmc-data", 4);
+ isa_register_ioport(dev, &s->io_data, s->iobase + APPLESMC_DATA_PORT);
+
+ memory_region_init_io(&s->io_cmd, &applesmc_cmd_io_ops, s,
+ "applesmc-cmd", 4);
+ isa_register_ioport(dev, &s->io_cmd, s->iobase + APPLESMC_CMD_PORT);
if (!s->osk || (strlen(s->osk) != 64)) {
fprintf(stderr, "WARNING: Using AppleSMC with invalid key\n");
--
1.7.3.4
- [Qemu-devel] [RFC][PATCH 00/15] Refactor portio dispatching, Jan Kiszka, 2013/05/06
- [Qemu-devel] [RFC][PATCH 03/15] wdt_ib700: replace register_ioport*, Jan Kiszka, 2013/05/06
- [Qemu-devel] [RFC][PATCH 14/15] ioport: Remove unused old dispatching services, Jan Kiszka, 2013/05/06
- [Qemu-devel] [RFC][PATCH 06/15] vt82c686: replace register_ioport*, Jan Kiszka, 2013/05/06
- [Qemu-devel] [RFC][PATCH 02/15] applesmc: replace register_ioport*,
Jan Kiszka <=
- [Qemu-devel] [RFC][PATCH 10/15] memory: Rework sub-page handling, Jan Kiszka, 2013/05/06
- Re: [Qemu-devel] [RFC][PATCH 10/15] memory: Rework sub-page handling, Paolo Bonzini, 2013/05/06
- Re: [Qemu-devel] [RFC][PATCH 10/15] memory: Rework sub-page handling, Peter Maydell, 2013/05/06
- Re: [Qemu-devel] [RFC][PATCH 10/15] memory: Rework sub-page handling, Paolo Bonzini, 2013/05/07
- Re: [Qemu-devel] [RFC][PATCH 10/15] memory: Rework sub-page handling, Paolo Bonzini, 2013/05/07
- Re: [Qemu-devel] [RFC][PATCH 10/15] memory: Rework sub-page handling, Jan Kiszka, 2013/05/07
- Re: [Qemu-devel] [RFC][PATCH 10/15] memory: Rework sub-page handling, Jan Kiszka, 2013/05/07
- Re: [Qemu-devel] [RFC][PATCH 10/15] memory: Rework sub-page handling, Paolo Bonzini, 2013/05/08
[Qemu-devel] [RFC][PATCH 08/15] isa: implement isa_is_ioport_assigned via memory_region_find, Jan Kiszka, 2013/05/06