[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH qom-cpu for-1.5 0/4] target-i386: X86CPU compati
From: |
Anthony Liguori |
Subject: |
Re: [Qemu-devel] [PATCH qom-cpu for-1.5 0/4] target-i386: X86CPU compatibility properties |
Date: |
Fri, 03 May 2013 11:46:59 -0500 |
User-agent: |
Notmuch/0.15.2+77~g661dcf8 (http://notmuchmail.org) Emacs/23.3.1 (x86_64-pc-linux-gnu) |
Andreas Färber <address@hidden> writes:
> Hello,
>
> It's easier adapting the infrastructure to our needs than working around it:
> X86CPU already has QOM properties today. What's lacking is model subclasses,
> and with the one X86CPU type its global properties are overwritten by models.
> But we already know the designated naming scheme for the models!
>
> So let's simply prepare compat_props for CPU models and make sure they are
> already picked up today.
>
> This works just fine for changing the 486 CPUID model value and avoids to
> redo the PC part once we have X86CPU subclasses.
> Tested using: ./QMP/qom-get /machine/icc-bridge/icc/child[0].model
So, what's left to do with subclass modelling?
How long are we going to need to carry something like this?
It's a clever work around but I'm a bit concerned that it would grow
beyond cpu subclasses and that we'd be stuck with it forever.
Regards,
Anthony Liguori
>
> For changing n270 CPUID flags we'll still need to resort to Eduardo's proposed
> helper functions for now.
>
> Regards,
> Andreas
>
> Cc: Eduardo Habkost <address@hidden>
> Cc: Igor Mammedov <address@hidden>
> Cc: H. Peter Anvin <address@hidden>
> Cc: Borislav Petkov <address@hidden>
> Cc: Anthony Liguori <address@hidden>
> Cc: Paolo Bonzini <address@hidden>
> Cc: Michael S. Tsirkin <address@hidden>
>
> Andreas Färber (4):
> qdev: Let qdev_prop_parse() pass through Error
> qdev: Introduce qdev_prop_set_custom_globals()
> target-i386: Emulate X86CPU subclasses for global properties
> target-i386: Change CPUID model of 486 to 8
>
> hw/core/qdev-properties.c | 50
> ++++++++++++++++++++++++++------------------
> hw/core/qdev.c | 7 ++++++-
> include/hw/i386/pc.h | 4 ++++
> include/hw/qdev-properties.h | 7 +++++--
> qdev-monitor.c | 6 +++++-
> target-i386/cpu.c | 11 +++++++++-
> 6 files changed, 60 insertions(+), 25 deletions(-)
>
> --
> 1.8.1.4
- [Qemu-devel] [PATCH qom-cpu for-1.5 0/4] target-i386: X86CPU compatibility properties, Andreas Färber, 2013/05/01
- [Qemu-devel] [PATCH qom-cpu for-1.5 3/4] target-i386: Emulate X86CPU subclasses for global properties, Andreas Färber, 2013/05/01
- [Qemu-devel] [PATCH qom-cpu for-1.5 2/4] qdev: Introduce qdev_prop_set_custom_globals(), Andreas Färber, 2013/05/01
- [Qemu-devel] [PATCH qom-cpu for-1.5 4/4] target-i386: Change CPUID model of 486 to 8, Andreas Färber, 2013/05/01
- [Qemu-devel] [PATCH qom-cpu for-1.5 1/4] qdev: Let qdev_prop_parse() pass through Error, Andreas Färber, 2013/05/01
- Re: [Qemu-devel] [PATCH qom-cpu for-1.5 0/4] target-i386: X86CPU compatibility properties,
Anthony Liguori <=
- Re: [Qemu-devel] [PATCH qom-cpu for-1.5 0/4] target-i386: X86CPU compatibility properties, Andreas Färber, 2013/05/06