qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 17/21] introduce memory_region_get_address() and


From: Paolo Bonzini
Subject: Re: [Qemu-devel] [PATCH 17/21] introduce memory_region_get_address() and use it in kvm/ioapic
Date: Sat, 27 Apr 2013 00:13:12 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130311 Thunderbird/17.0.4

Il 26/04/2013 19:46, Igor Mammedov ha scritto:
>> > But as the address can't be changed (yet), the entire patch could be 
>> > simply:
>> > -    kioapic->base_address = s->busdev.mmio[0].addr;
>> > +    kioapic->base_address = IO_APIC_DEFAULT_ADDRESS;
> It's a bit fragile, but that for sure simpler and can work.
> 
> Jan, Paolo,
> Are you ok with this approach? 
> 

I think extending memory_region_find is a good idea anyway, and at this
point I don't see a reason to do the above change...

Paolo



reply via email to

[Prev in Thread] Current Thread [Next in Thread]