Re: [Qemu-devel] [PATCH v3 14/24] instrument: Add internal control interface

[Paolo Bonzini]

Il 26/04/2013 17:25, Lluís Vilanova ha scritto:
> Paolo Bonzini writes:
> 
>> Il 21/04/2013 21:12, Lluís Vilanova ha scritto:
>>> diff --git a/Makefile.objs b/Makefile.objs
>>> index 5f8ea2d..4fb565b 100644
>>> --- a/Makefile.objs
>>> +++ b/Makefile.objs
>>> @@ -94,6 +94,7 @@ common-obj-y += disas/
>>> # instrumentation
>>>
>>> tools-obj-y += instrument/
>>> +target-obj-y += instrument/
>>>
> 
>> Why does instrument/ have to be compiled once per target?
> 
>> If you can compile it just once, then libqemuutil.a and util-obj-y will do.
> 
> It looks like that after some re-merges, the patch was placed too early in the
> series. This is necessary later for files like instrument/cmdline.c and
> instrument/api-control.c (patch 18).

The point of using a static library is exactly to leave out files
automatically if they are not used.  Just put it into libqemuutil.a, and
tools will not pick it up.

Paolo