[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 10/21] acpi_piix4: add infrastructure to send CP
From: |
Eduardo Habkost |
Subject: |
Re: [Qemu-devel] [PATCH 10/21] acpi_piix4: add infrastructure to send CPU hot-plug GPE to guest |
Date: |
Tue, 23 Apr 2013 10:58:35 -0300 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
On Tue, Apr 23, 2013 at 03:43:51PM +0200, Juan Quintela wrote:
> Igor Mammedov <address@hidden> wrote:
> > * introduce processor status bitmask visible to guest at 0xaf00 addr,
> > where ACPI asl code expects it
> > * set bit corresponding to APIC ID in processor status bitmask on
> > receiving CPU hot-plug notification
> > * trigger CPU hot-plug SCI, to notify guest about CPU hot-plug event
> >
> > Signed-off-by: Igor Mammedov <address@hidden>
>
> This is wrong (or at least supperfluous)
>
> > +static int piix4_init_cpu_status(Object *obj, void *opaque)
> > +{
> > + struct cpu_status *g = (struct cpu_status *)opaque;
> > + Object *cpu_obj = object_dynamic_cast(obj, TYPE_CPU);
> > +
> > + if (cpu_obj) {
> > + struct Error *error = NULL;
>
> we set error to NULL
>
> > + CPUClass *k = CPU_GET_CLASS(cpu_obj);
> > + int64_t id = k->get_arch_id(CPU(cpu_obj));
> > +
> > + if (error) {
>
> and without touching error we test if it is != NULL.
>
>
> something is missing here?
Looks like a leftover from v1, that called object_property_get_int()
(with an error argument) instead of k->get_arch_id().
--
Eduardo
- [Qemu-devel] [PATCH 10/21] acpi_piix4: add infrastructure to send CPU hot-plug GPE to guest, (continued)
Re: [Qemu-devel] [PATCH 10/21] acpi_piix4: add infrastructure to send CPU hot-plug GPE to guest, Juan Quintela, 2013/04/23
[Qemu-devel] [PATCH 10/21 DISGISED v6] acpi_piix4: add infrastructure to send CPU hot-plug GPE to guest, Igor Mammedov, 2013/04/23
- Re: [Qemu-devel] [PATCH 10/21 DISGISED v6] acpi_piix4: add infrastructure to send CPU hot-plug GPE to guest, Igor Mammedov, 2013/04/24
- Re: [Qemu-devel] [PATCH 10/21 DISGISED v6] acpi_piix4: add infrastructure to send CPU hot-plug GPE to guest, Eduardo Habkost, 2013/04/24
- Re: [Qemu-devel] [PATCH 10/21 DISGISED v6] acpi_piix4: add infrastructure to send CPU hot-plug GPE to guest, Paolo Bonzini, 2013/04/24
- Re: [Qemu-devel] [PATCH 10/21 DISGISED v6] acpi_piix4: add infrastructure to send CPU hot-plug GPE to guest, Andreas Färber, 2013/04/24
- Re: [Qemu-devel] [PATCH 10/21 DISGISED v6] acpi_piix4: add infrastructure to send CPU hot-plug GPE to guest, Igor Mammedov, 2013/04/24
[Qemu-devel] [PATCH 08/19 v7] acpi_piix4: add infrastructure to send CPU hot-plug GPE to guest, Igor Mammedov, 2013/04/24